Flex Addon for Spring Roo - Compatibility Update

[tbird]

Hey guys,

Just now getting around to reviewing this...just scanned it quickly, but it looks great so far, thanks!

Thomas - Can you do me a favor and attach your patch to this Jira?
https://jira.springsource.org/browse/ROOFLEX-40

I need that before I can officially accept and commit any of your changes.

Also, let me know your last name so I can add you as an @author as needed.

**UPDATE**

I attached the patch to JIRA bug. Let me know when/if it gets accepted. Thanks!

Sure thing!

I will update this post and private message you once I've attached the patch. Also, my last name is Fowler for the authoring stuff.


Thanks,

Thomas

[jeremyg484]

Got it, thanks! Reviewing now...I'll update here once a 1.1.1 compatible snapshot is available.

[tbird]

Got it, thanks! Reviewing now...I'll update here once a 1.1.1 compatible snapshot is available.

No problem; glad I could help!

[jeremyg484]

Ok, changes have been merged after doing a bit of cleanup. Still need to review a few more things before I close the ticket completely, but I believe the snapshot build that just completed (specifically this one: http://maven.springframework.org/sna...075648-225.jar) should be in a working state with Roo 1.1.1.

One thing I pulled back out was the change that adds the [Bindable] tag to all of the generated entities. My current feeling is that this is not something we should do (just google "flex bindable performance" to get an idea of why), but I'm open to being convinced in the other direction. Either way though, it should be under a separate Jira issue.

[MikeOliverAZ]

Excellent, I just finished installing testdrive, so timing is perfect!

[tbird]

Ok, changes have been merged after doing a bit of cleanup. Still need to review a few more things before I close the ticket completely, but I believe the snapshot build that just completed (specifically this one: http://maven.springframework.org/sna...075648-225.jar) should be in a working state with Roo 1.1.1.

One thing I pulled back out was the change that adds the [Bindable] tag to all of the generated entities. My current feeling is that this is not something we should do (just google "flex bindable performance" to get an idea of why), but I'm open to being convinced in the other direction. Either way though, it should be under a separate Jira issue.

Hi Jeremy-

Thanks for getting this patch into the build so quickly! I understand your concern about the 'Bindable' metadata. I had included that initially to get rid of the binding warnings in the auto-gen'd MXML. I think a good alternative to declaring the class/object 'Bindable' would be to add a property-specific 'Bindable' metadata with an 'event' attribute for each property in the object. This would at least eliminate most of the auto-gen'd code produced by the 'Bindable' metadata on the class and with that the overhead which comes with it. Let me know your thoughts and thanks again!

Cheers,


Thomas

[Admir]

I am new to Roo and trying to use roo 1.1.1 with the latest flex addon nightly build with no success. Using STS 2.5.2 i manage to create a project but then STS just hangs building workspace. If i try to create a project without STS and using command line, this is what happens. Am I doing something wrong?

Welcome to Spring Roo. For assistance press TAB or type "hint" then hit ENTER.
roo> project --topLevelPackage com.admir.test
Created C:\Users\Admir\rootest2\pom.xml
Created SRC_MAIN_JAVA
Created SRC_MAIN_RESOURCES
Created SRC_TEST_JAVA
Created SRC_TEST_RESOURCES
Created SRC_MAIN_WEBAPP
Created SRC_MAIN_RESOURCES\META-INF\spring
Created SRC_MAIN_FLEX
Created LIBS
Undo create LIBS
Undo create SRC_MAIN_FLEX
Undo create SRC_MAIN_RESOURCES\META-INF\spring
Undo create SRC_MAIN_WEBAPP
Undo create SRC_TEST_RESOURCES
Undo create SRC_TEST_JAVA
Undo create SRC_MAIN_RESOURCES
Undo create SRC_MAIN_JAVA
Undo create C:\Users\Admir\rootest2\pom.xml
ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(Hash
Map.java:793)
com.admir.test roo>

Thanks

[MikeOliverAZ]

Excellent, I just finished installing testdrive, so timing is perfect!

Well I downloaded the build snapshot and put the M2 jar in the Spring Roo bundle.

Spring ROO no longer hangs, but now I am getting,

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) org.springframework.flex:spring-flex-core:jar:1.5.0.BUILD-SNAPSHOT

Try downloading the file manually from the project website.

Then, install it using the command:
mvn install:install-file -DgroupId=org.springframework.flex -DartifactId=spring-flex-core -Dversion=1.5.0.BUILD-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file

Is this in the SNAPSHOT repository, if so the pom that was generated with ROO in STS 2.5.2 doesn't have that in the template as the pom in my project doesn't have the SNAPSHOT repository listed.

[MikeOliverAZ]

Well I downloaded the build snapshot and put the M2 jar in the Spring Roo bundle.

I found the snapshot repository xml and added it to the pom and got everything I needed, or at least I thought I did as the build errors went away.

I tried to create a project with ROO and here is the roo.log

// Spring Roo 1.1.1.RELEASE [rev 156ccd6] log opened at 2011-02-21 06:40:36
project --topLevelPackage com.corent.kangaroo --projectName Kangaroo --java 6
// Spring Roo 1.1.1.RELEASE [rev 156ccd6] log closed at 2011-02-21 06:40:43
// Spring Roo 1.1.1.RELEASE [rev 156ccd6] log opened at 2011-02-21 06:41:55
flex setup
entity --class ~.domain.Rsvp
field string code --notNull --sizeMin 1 --sizeMax 30
field string email --sizeMax 30
field number attending --type java.lang.Integer
field date confirmed --type java.util.Date
flex remoting scaffold --name ~.service.KangarooService
flex remoting all --package ~.service

When I tried to run it, I got...

Feb 21, 2011 1:02:09 PM org.apache.catalina.core.ApplicationDispatcher invoke
SEVERE: Servlet.service() for servlet Kangaroo threw exception
javax.servlet.ServletException: Circular view path [resourceNotFound]: would dispatch back to the current handler URL [/Kangaroo/resourceNotFound] again. Check your ViewResolver setup! (Hint: This may be the result of an unspecified view, due to default view name generation.)
at org.springframework.web.servlet.view.InternalResou rceView.prepareForRendering(InternalResourceView.j ava:292)
at org.springframework.web.servlet.view.InternalResou rceView.renderMergedOutputModel(InternalResourceVi ew.java:214)
at org.springframework.web.servlet.view.AbstractView. render(AbstractView.java:250)
at org.springframework.web.servlet.DispatcherServlet. render(DispatcherServlet.java:1047)
at org.springframework.web.servlet.DispatcherServlet. doDispatch(DispatcherServlet.java:817)
at org.springframework.web.servlet.DispatcherServlet. doService(DispatcherServlet.java:719)
at org.springframework.web.servlet.FrameworkServlet.p rocessRequest(FrameworkServlet.java:644)
at org.springframework.web.servlet.FrameworkServlet.d oGet(FrameworkServlet.java:549)

I was following http://blog.springsource.com/2009/05/27/roo-part-2/
and ch9 of http://static.springsource.org/sprin...html#flexaddon

what did I do wrong?

[tbird]

flex setup
entity --class ~.domain.Rsvp
field string code --notNull --sizeMin 1 --sizeMax 30
field string email --sizeMax 30
field number attending --type java.lang.Integer
field date confirmed --type java.util.Date
flex remoting scaffold --name ~.service.KangarooService
flex remoting all --package ~.service

Hi Mike-

I'm not quite sure about this error, but one thing I might suggest would be to reorder the roo statements you're using. You might try something like this:

entity --class ~.domain.Rsvp
field string code --notNull --sizeMin 1 --sizeMax 30
field string email --sizeMax 30
field number attending --type java.lang.Integer
field date confirmed --type java.util.Date
flex setup
flex remoting all --package ~.service

Note that I omitted this statement

flex remoting scaffold --name ~.service.KangarooService

I did this because the last statement in the reordered version will create this for you. To explain this a bit further, you typically use the 'flex remoting scaffold --name ~.services.SomeService' statement when you don't want to scaffold every domain object in your application (i.e. you only want to scaffold specific objects.) Let me know if this works and if not I'll try to help you further.

Cheers,


Thomas