Page 2 of 2 FirstFirst 12
Results 11 to 14 of 14

Thread: Plan <attributes/> and <property/> usage in nested plans

  1. #11
    Join Date
    Oct 2008
    Location
    Winchester, UK
    Posts
    535

    Default

    Thanks for your patience: at last I understand! We need to shoot the chicken or break the egg. :-)

    What I mean is that property resolution should not be happening under the PlanBridge, which only needs to extract the name and version from a plan file. Therefore, in retrospect (since properties were, I think, added relatively late in the day), reusing PlanReader was a mistake.

    A common helper class, called something like PlanIdentityParser, should be factored out of PlanReader. PlanIdentityParser should be responsible for extracting the name and version from a plan file. PlanReader and PlanBridge can use PlanIdentityParser. Then PlanBridge won't try to resolve property placeholders.
    Glyn Normington
    SpringSource

  2. #12
    Join Date
    Dec 2005
    Location
    Philadelphia, PA, USA
    Posts
    228

    Default

    That would do the trick. Should I create an issue for this?
    Thanks
    Dmitry

  3. #13
    Join Date
    Oct 2008
    Location
    Winchester, UK
    Posts
    535

    Default

    If you like, but we are planning on doing a big cull of the issues in order to clear the air ready for Virgo, so why not add this to a list of proposed improvements and float it on the Virgo forum until such time as we have a bug tracker for Virgo?
    Glyn Normington
    SpringSource

  4. #14
    Join Date
    Dec 2005
    Location
    Philadelphia, PA, USA
    Posts
    228

    Default

    Will do.

    Thanks for your help.
    Thanks
    Dmitry

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •