Autowiring in Aspects

[ketankhairnar]

I am using Spring MVC for web applications and for Audit logging I am using AOP and it works when I log the changes using log4j. I want to dump these changes to database and for this I am using Autowired DAO inside my Aspect bean as below.

Can somebody let me know why it fails? I am really not sure about the sequence of things when aspects come in to play at runtime.

@Aspect
public class LoggingInterceptor
{
    Log log = LogFactory.getLog(LoggingInterceptor.class);

    @Autowired
    private AuditData auditData;

    @Around("@annotation(com.xx.yy.util.audit.Auditable)")
    public Object profile(ProceedingJoinPoint pjp) throws Throwable
    {
        final String currentUser = SecurityContextHolder.getContext().getAuthentication().getName();
        try
        {

            Object resultValue = pjp.proceed();
            if (log.isErrorEnabled())
            {
                logInfo(currentUser, pjp);
                System.out.println("dao: " + auditData); // am getting this as null
                // logAudit(currentUser, pjp); //dump changes to db 
            }
            return resultValue;
        }
        finally
        {
            // sw.stop();

        }
    }
    
}

[ramnivas]

The aspect itself looks fine. It is probably your configuration that is causing the problem. Do you have other non-aspect beans with the DAO as an autowired dependency? Does that work?

-Ramnivas

[ketankhairnar]

I do have a Service bean/Controller bean with with this dao as Autowired dependency and that works fine. I tried these combination just for testing.
Configuration is as below:

	<!-- Turn on AspectJ @Configurable support -->
	<aop:aspectj-autoproxy proxy-target-class="false" />
	<bean id="logInterceptor" class="com.xx.yy.util.audit.LoggingInterceptor" >
		<property name="dao">
			<ref bean="auditData"/>
		</property>
	</bean>

Also myDAO don't have interface. is that a problem

[ramnivas]

First, the comment is incorrect :-) <aop:aspectj-autoproxy> does NOT turn on @Configurable support.

You don't have property named "dao" in your aspect (it is named "auditData"). Did you not get an error for this?

-Ramnivas

[ketankhairnar]

my bad, sorry for the confusion
I tried both approaches :

1) putting "dao" in Aspect and configuration is done as mentioned above. So I had getter and setter for dao

2) using @Autowired annotation as in the very first snippet.

[ramnivas]

It may help if you put together exact code that doesn't work. What you describe is a common scenario, so it must be a combination of how you put things together that causes it not to work.

-Ramnivas