Bundlor 1.0.0.RC1: MANIFEST.MF is not in the jar

[ctranxuan]

Hi all,
I am testing Bundlor 1.0.0.RC1 with maven but I don't manage to include my generated MANIFEST.MF in the jar: I just got the default one generated by maven. Nevertheless, it is generated in the target/classes/META-INF but not in the generated jar.
Furthermore, it seems that my template.mf is not taken in account since some properties of the generated manifest are not overriden (e.g. the bundleVersion).

I attach a zip of my project. If someone has an idea about what I am doing wrong...

I used:
- Bundlor 1.0.0.RC1
- maven 2.2.1 and maven 3
- Windows 7 (64bits)

Thanks in advance,

Cédric.

[dsklyut]

Add this for jar projects:

<plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-jar-plugin</artifactId>
                <configuration>
                    <archive>
                        <manifestFile>${bundlor.manifest.output.dir}/META-INF/MANIFEST.MF</manifestFile>
                    </archive>
                </configuration>
            </plugin>

bundlor.manifest.output.dir is location where bundlor places MANIFEST.MF. By default it will in in ${project.build.outputDirectory}.

[ctranxuan]

Thanks! It works fine!
But I still got the issue about the template.mf file that is not taken in account. Have I also missed a maven configuration somewhere?

[dsklyut]

That could be a defect. I am also noticing that bundlor overrides BundleSymbolic name with maven ${project.artifactId}

[ctranxuan]

It looks like. I have run maven using bundlor 1.0.0.M6 and the template.mf is well taken in account.
Thanks again for the help!

Cédric.

[Ben Hale]

@ctranxuan and @Dimitry,

You guys are right, there's a precedence problem here. The precedence currently works such that if a BSN or BV is specified in the Maven configuration it overrides anything specified in the template. This puts it in line with all of the other user-specifible values.

However (and this is unlike the ANT task), we also aggressively specify default values for nearly every piece of configuration you can do through Maven. This leads to the defaults always overriding the template. I could reverse this, but it becomes non-standard to the rest of Bundlor, as well as to other configuration parameters potentially.

So my question is, as a user, how would you like the precedence to work? This is a change I'd like to make (if needed) for 1.0.0.

[muchun3113]

I agree with the above statement. Good point!!

[muchun3113]

Different people have different points of view. That’s why we have different opinions.
You may use Bing or Google to have a try.



To see more, check here:
http://www.softpedia.com/get/Office-...peg-Free.shtml