change dependencies manually will add repeated dependencies

[smoradi]

Hi,

I've done below steps to get this issue :
1_Open pom.xml file in STS
2_Add TAB indent in front of some dependencies , (for making looks better;-) )
3_Generate new Controller

controller scaffold --name ~.web.RoleController

4_These repeated dependencies will goes at end of dependencies .

    <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>org.springframework.web</artifactId>
            <version>${spring.version}</version>
        </dependency>
    <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>org.springframework.web.servlet</artifactId>
            <version>${spring.version}</version>
        </dependency>
    <dependency>
            <groupId>org.springframework.webflow</groupId>
            <artifactId>org.springframework.js</artifactId>
            <version>2.0.8.RELEASE</version>
        </dependency>
    <dependency>
            <groupId>org.apache.commons</groupId>
            <artifactId>com.springsource.org.apache.commons.fileupload</artifactId>
            <version>1.2.0</version>
        </dependency>
    <dependency>
            <groupId>org.tuckey</groupId>
            <artifactId>com.springsource.org.tuckey.web.filters.urlrewrite</artifactId>
            <version>3.1.0</version>
        </dependency>
    <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>com.springsource.javax.servlet.jsp.jstl</artifactId>
            <version>1.2.0</version>
        </dependency>
    <dependency>
            <groupId>org.apache.tiles</groupId>
            <artifactId>com.springsource.org.apache.tiles</artifactId>
            <version>2.1.3</version>
        </dependency>
    <dependency>
            <groupId>org.apache.tiles</groupId>
            <artifactId>com.springsource.org.apache.tiles.jsp</artifactId>
            <version>2.1.3</version>
        </dependency>
    <dependency>
            <groupId>org.apache.tiles</groupId>
            <artifactId>com.springsource.org.apache.tiles.core</artifactId>
            <version>2.1.3</version>
        </dependency>
    <dependency>
            <groupId>org.apache.el</groupId>
            <artifactId>com.springsource.org.apache.el</artifactId>
            <version>6.0.20</version>
        </dependency>

I've also add below parts in my pom.xml

...
	<build>
		<plugins>
...
            <plugin>
            	<groupId>org.codehaus.mojo</groupId>
            	<artifactId>dbunit-maven-plugin</artifactId>
            	<version>1.0-beta-3</version>
            	<configuration>
            		<dataTypeFactoryName>${dbunit.dataTypeFactoryName}</dataTypeFactoryName>
            		<driver>${jdbc.driverClassName}</driver>
            		<username>${jdbc.username}</username>
            		<password>${jdbc.password}</password>
            		<url>${jdbc.url}</url>
            		<src>src/test/resources/sample-data.xml</src>
            		<type>${dbunit.operation.type}</type>
            		<schema>${dbunit.schema}</schema>
            		<skip>${maven.test.skip}</skip>
            		<transaction>true</transaction>
            	</configuration>
            	<executions>
            		<execution>
            			<phase>test</phase>
            			<goals>
            				<goal>operation</goal>
            			</goals>
            		</execution>
            	</executions>
            	<dependencies>
            		<dependency>
            			<groupId>${jdbc.groupId}</groupId>
            			<artifactId>${jdbc.artifactId}</artifactId>
            			<version>${jdbc.version}</version>
            		</dependency>
            	</dependencies>
            </plugin>
        </plugins>
	</build>

	<properties>
		<spring.version>3.0.0.RC1</spring.version>
		<aspectj.version>1.6.5.RELEASE</aspectj.version>
	
		<!-- Database settings -->
        <dbunit.dataTypeFactoryName>org.dbunit.ext.mysql.MySqlDataTypeFactory</dbunit.dataTypeFactoryName>
        <dbunit.operation.type>CLEAN_INSERT</dbunit.operation.type>
        <hibernate.dialect>org.hibernate.dialect.MySQL5InnoDBDialect</hibernate.dialect>
        <jdbc.groupId>com.mysql.jdbc</jdbc.groupId>
        <jdbc.artifactId>com.springsource.com.mysql.jdbc</jdbc.artifactId>
        <jdbc.version>5.1.6</jdbc.version>
        <jdbc.driverClassName>com.mysql.jdbc.Driver</jdbc.driverClassName>
        <jdbc.url><![CDATA[jdbc:mysql://localhost/wha?createDatabaseIfNotExist=true&amp;useUnicode=true&amp;characterEncoding=utf-8]]></jdbc.url>
        <jdbc.username>root</jdbc.username>
        <jdbc.password>root</jdbc.password>
		
	</properties>

</project>

I am working with version 1.0.0.RC2 . I've tried 1.0.0.RC3 in trunk! , result is same.
I don't know this issue is reported or not but I am hopeful you could reproduce it and fix it for me :-) Thank you !
Cheers,
Sid

[Ben Alex]

Hi Sid, would you mind logging this as a bug in Jira and attach the various XML files (before you tabbed them, after you tabbed them, after Roo modifies them) so we can look into it? I ask for files because it could be line ending related, so please also note in the "environment" section of the Jira issue what operating system and JVM you're using. Thanks!

[smoradi]

I've created new bug in Jira : http://jira.springframework.org/browse/ROO-354

I've attached two version of my pom.xml (curent and after) , I have to walk through before revisions to find correct pom.xml (before). Thank you !

[Ben Alex]

Fixed in SVN. Will be fixed in Roo 1.0.0.RC3.