file:outbound-channel-adapter : file extension ".writing" issue

[munger]

Hi again,

Sorry not coming with a full compiled test case, but i've looked at the source code in the spring-integration-file package, and i think the problem may come from that the rename function is not working, but its return value is not processed here :

private File handleFileMessage(File sourceFile, File tempFile, File resultFile) throws IOException {
		if (this.deleteSourceFiles) {
			if (sourceFile.renameTo(resultFile)) {
				return resultFile;
			}
			if (logger.isInfoEnabled()) {
				logger.info(String.format("Failed to move file '%s'. Using copy and delete fallback.",
						sourceFile.getAbsolutePath()));
			}
		}
		FileCopyUtils.copy(sourceFile, tempFile);
		tempFile.renameTo(resultFile);
		if (this.deleteSourceFiles) {
			sourceFile.delete();
		}
		return resultFile;
	}

	private File handleByteArrayMessage(byte[] bytes, File originalFile, File tempFile, File resultFile) throws IOException {
		FileCopyUtils.copy(bytes, tempFile);
		tempFile.renameTo(resultFile);
		if (this.deleteSourceFiles && originalFile != null) {
			originalFile.delete();
		}
		return resultFile;
	}

	private File handleStringMessage(String content, File originalFile, File tempFile, File resultFile) throws IOException {
		OutputStreamWriter writer = new OutputStreamWriter(new FileOutputStream(tempFile), this.charset);
		FileCopyUtils.copy(content, writer);
		tempFile.renameTo(resultFile);
		if (this.deleteSourceFiles && originalFile != null) {
			originalFile.delete();
		}
		return resultFile;
	}

What about deleting src file first and then renaming the tempFile, if first rename failed (returned false) ?

Thanks for your help

Max

[SARAL SAXENA]

have to see first ..!!

[munger]

What do you wanna see ?

[munger]

Problem solved re-writing and subclassing FileWritingMessageHandler like follows :

@Override
	protected File handleStringMessage(String content, File originalFile, File tempFile, File resultFile) throws IOException {
		getLogger().debug("handling string message");
		OutputStreamWriter writer = new OutputStreamWriter(new FileOutputStream(tempFile), this.getCharset());
		FileCopyUtils.copy(content, writer);
		renameTo(tempFile, resultFile);
		if (this.isDeleteSourceFiles() && originalFile != null) {
			originalFile.delete();
		}
		return resultFile;
	}



	private void renameTo(File tempFile, File resultFile) {
		if (resultFile != null && resultFile.exists())
		{
		resultFile.setWritable(true,false);
		resultFile.delete();
		if (!tempFile.renameTo(resultFile))
			getLogger().debug("rename KO from " + tempFile.getAbsolutePath() + " to " + resultFile.getAbsolutePath());
		}
	else
		{
		if (!tempFile.renameTo(resultFile))
			getLogger().debug("rename KO from " + tempFile.getAbsolutePath() + " to " + resultFile.getAbsolutePath());
		
		}
	}

Thanks for you help.

[oleg.zhurakousky]

@munger

Could you please rais a jIRA issue for that?

[munger]

Done : INT-2278
Thanks !