PropertyOverrideConfigurer does not work

[Sascha Schäfer]

Hello,

I have a problem to define the connection properties for my data source.

I have defined the properties for the data source in the spring context which are used in the default case.
But at runtime I get other parameters for the data source. So I created an object of PropertyOverrideConfigurer in my java code to assign the parameters to that object. After that I refresh my application context. Here is the code snippet:

PropertyOverrideConfigurer propertyOverrideConfigurer = new PropertyOverrideConfigurer();
propertyOverrideConfigurer.setProperties( myProperties );
propertyOverrideConfigurer.postProcessBeanFactory( applicationContext.getBeanFactory() );
applicationContext.refresh();

But nothing happens. The data source is still using the default properties which are defined in the context.xml.
Did I forget something?

Kind regards
Sascha

[Marten Deinum]

The ApplicationContext is going to refresh itself which means destroy everything and reload, so what you are doing here is well pretty much useless. You need to register the PropertyOverrideConfigurer with the BeanFactory/ApplicationContext not externally execute the postProcessBeanFactory because that isn't going to work/help.

on refresh the 'refreshBeanFactory' method is called which first destroys the beans and then closes the BeanFactory, which basically means undoing what you have done.

P.S. Use [ code][/code ] tags when posting code.

PropertyOverrideConfigurer propertyOverrideConfigurer = new PropertyOverrideConfigurer();
propertyOverrideConfigurer.setProperties( myProperties );
applicationContext.addBeanFactoryPostProcessor(propertyOverrideConfigurer);
applicationContext.refresh();

I assume here that 'applicationContext' is a ConfigurableApplicationContext.

[Sascha Schäfer]

Yes, my applicationcontext is an instance of ClassPathXmlApplicationContext.

I removed the calling of applicationContext.refresh(), but it still does not work. I have to defined the PropertyOverrideConfigurer externally because I have to set the Properties to the PropertyOverrideConfigurer at runtime.

Maybe there is another possibility to overwrite the properties at runtime?

Kind regards
Sascha

[Marten Deinum]

Sigh... Have you actually READ my post...

[Sascha Schäfer]

Hmm ... I think so. Maybe I read your solution over. Can you give me a more detailed description of your solution?

Kind regards,
Sascha

[Marten Deinum]

Compare the code below (my code)

PropertyOverrideConfigurer propertyOverrideConfigurer = new PropertyOverrideConfigurer();
propertyOverrideConfigurer.setProperties( myProperties );
applicationContext.addBeanFactoryPostProcessor(propertyOverrideConfigurer);
applicationContext.refresh();

with your code

PropertyOverrideConfigurer propertyOverrideConfigurer = new PropertyOverrideConfigurer();
propertyOverrideConfigurer.setProperties( myProperties );
propertyOverrideConfigurer.postProcessBeanFactory( applicationContext.getBeanFactory() );
applicationContext.refresh();

It is just a single line but an important difference... (hence my suggestion that you re-read my post).

I no where said that you cannot create the bean externally, you must only REGISTER the bean else everything you do is useless....

[Sascha Schäfer]

I am sorry that I read your solution over.

Now it works. I am deeply indebted to you. Thank you.

Kind regards,
Sascha