Pointcuts on specific subclasses?

[stewartcambridge]

Dear Spring Forum,

I have some Spring MVC controllers subclassing from an abstract controller:

public abstract class AbstractController implements Controller {
    @Override
    public ModelAndView handleRequest(HttpServletRequest request, HttpServletResponse response) { ... }
}

public class ConcreteController1 extends AbstractController { ... }
public class ConcreteController2 extends AbstractController { ... }

I am trying to add some advice when the handleRequest() method of a specific subclass executes:

<aop:aspect id="viewSwitchAspect" ref="viewSwitchAdvice">
    <aop:before method="assignView"
        pointcut="execution(* web.controller.ConcreteController1.handleRequest(..))"/>
</aop:aspect>

This configuration does not cause the advice to be executed.

But this advice does:

<aop:aspect id="viewSwitchAspect" ref="viewSwitchAdvice">
    <aop:before method="assignView"
        pointcut="execution(* web.controller.*.handleRequest(..))"/>
</aop:aspect>

My guess is that the reason is that the handleRequest() method is implemented in the abstract superclass. I don't want ConcreteController2 to receive this advice.

How can I achieve this?

Thanks,

Stewart

[Marten Deinum]

pointcut="execution(* web.controller.*.handleRequest(..)) && target(web.controller.ConcreteController1)"

Something like that should do it.

[stewartcambridge]

Excellent! Thank you.