Jencks, Hibernate, Geronimo and Spring 2.0.6 -> 2.5.2 upgrade problem

[driftwood]

Hi,

I am trying to upgrade to spring 2.5.2 with the above mentioned packages in use. Code that used to work throws the follow exception with 2.5.2.

javax.naming.NoInitialContextException: Need to specify class name in environment or system property, or as an applet parameter, or in an application resource file:  java.naming.factory.initial
       at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:645)
       at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:247)
       at javax.naming.InitialContext.getURLOrDefaultInitCtx(InitialContext.java:284)
       at javax.naming.InitialContext.lookup(InitialContext.java:351)
       at org.hibernate.transaction.JTATransaction.<init>(JTATransaction.java:60)
       at org.hibernate.transaction.JTATransactionFactory.createTransaction(JTATransactionFactory.java:53)
       at org.hibernate.jdbc.JDBCContext.getTransaction(JDBCContext.java:177)
       at org.hibernate.impl.SessionImpl.getTransaction(SessionImpl.java:1279)
       at org.hibernate.context.ThreadLocalSessionContext.currentSession(ThreadLocalSessionContext.java:78)
       at org.hibernate.impl.SessionFactoryImpl.getCurrentSession(SessionFactoryImpl.java:508)

I have noticed the following, but doubt that it is why this is happening. It seems that in 2.0.6 SessionFactoryImpl was fronted with a proxy. When getCurrentSession was called the proxy instead invoked a method on SessionFactoryUtils. This specific code was located in TransactionAwareInvocationHandler. In 2.5.2 SessionFactoryImpl is not fronted by a proxy and is called directly.

I would like to know, out of interest, why / how it changed.

But my actual question is , can anybody shed some light on why I am getting this exception in 2.5.2, is there something that I need to change or do differently?

any help appreciated.

[Marten Deinum]

As of Spring 2.5 a proxy isn't needed anymore. Hibernate provides hooks to retrieve the current session.

Judging by your stacktrace you misconfigured you LocalSessionFactoryBean as judging from your stacktrace Hibernate is managing your transactions instead of Spring.

[driftwood]

Thanks for your reply, I will check it out tomorrow.

Can you maybe explain to me why the config would work with 2.0.6 and not with 2.5.2?

[Marten Deinum]

Due to the proxy. With the proxy each call to getCurrentSession() would be intercepted and redirected, regardless of the settings of hibernate. With the new approach it delegates to hibernate, so uses those settings.

If you post your configuration we might figure out the issue.

[driftwood]

Hi,

Here is the config as requested. I must admit, I recently inherited the code, so I am still trying to make heads or tails of what it all means. Can you maybe point me to some reading material to understand how spring works with all this?

  <bean id="connectionTracker"
        class="org.apache.geronimo.connector.outbound.connectiontracking.ConnectionTrackingCoordinator"/>

  <bean id="baseConnectionManager" class="org.jencks.factory.ConnectionManagerFactoryBean" abstract="true">
    <property name="transactionManager" ref="transactionManager"/>
    <property name="pooling" value="true"/>
    <property name="poolMinSize" value="5"/>
    <property name="poolMaxSize" value="100"/>
    <property name="connectionTracker" ref="connectionTracker"/>
  </bean>

  <bean id="transactionManager" class="org.jencks.factory.TransactionManagerFactoryBean">
    <property name="transactionLog">
      <bean class="org.apache.geronimo.transaction.log.UnrecoverableLog"/>
    </property>
    <property name="defaultTransactionTimeoutSeconds" value="3600"/>
  </bean>

  <alias name="transactionManager" alias="userTransaction"/>

Hope this is what you need.

Thanks for your help

[Marten Deinum]

The reference guide is a good start.

However what I really wanted to see was your LocalSessionFactoryBean and it's configuration. That is missing from what you posted here.

[driftwood]

We have extended the LocalSessionFactoryBean and configured it as below.

  <bean id="hibernateSessionFactoryAbstract" class="net.devstream.commons.util.spring.EntityResolverLocalSessionFactoryBean" abstract="true">
    <property name="entityResolverClass" value="net.devstream.commons.util.hibernate.HibernateXMLFragmentClasspathEntityResolver"/>
    <property name="dataSource" ref="datasource"/>
    <property name="entityInterceptor" ref="hibernateInterceptor"/>
    <property name="hibernateConfigurationCreator" ref="hibernateConfigurationCreator"/>
    <property name="eventListeners">
      <map>
        <entry key="load">
          <bean class="net.devstream.commons.appframework.persistence.HibernateLoadEventListener"/>
        </entry>
      </map>
    </property>
    <property name="jtaTransactionManager" ref="transactionManager"/>
  </bean>

The transactionManager is defined in above post.

[Marten Deinum]

You extended it so there is additional stuff going on.

Probably there is some custom ConfigurationCreator (no idea what that does?!), but probably generates some custom/additional configuration (which might screw things up).

Next to that this bean is abstract so there must be another bean which has this bean as a parent..

[driftwood]

The hibernateConfigurationCreator implementation just calls

new Configuration();

. We then set the entityResolver on the configuration, that is the only modification to the stock standard configuration.

The beans that has the hibernateSessionFactoryAbstract bean as parent just sets the configLocation. Here is the configLocation file content for this specific scenario:

<hibernate-configuration>
  <session-factory>
    <property name="hibernate.dialect">net.devstream.commons.persistence.hibernate.dialect.PostgreSQLDialect</property>
    <property name="hibernate.show_sql">false</property>
    <property name="hibernate.current_session_context_class">thread</property>
    <property name="hibernate.cache.use_query_cache">false</property>
    <property name="hibernate.cache.provider_class">org.hibernate.cache.HashtableCacheProvider</property>
  </session-factory>

</hibernate-configuration>

The concrete sessionFactory is then injected into the hibernateTemplate.

[Marten Deinum]

Wouldn't it be easier/better to override the 'postProcessConfiguration' method and then set the entityResolver? Saves you a class and creation of (another?) Configuration object.

Well the culprit is in the configuration you showed. Remove the 'hibernate.current_session_context_class' and then it should work again.