execute methods of StoredProcedure

[wadissimo]

Hello!
Could u tell me why execute methods of Stored Procedure are public?
I think that they should be protected, because they should be used only by subclasses. Also subclass cannot make it invisible (protected or private). If they were protected, subclass would make it public if it needs to.
Thanks

[Marten Deinum]

Why? That way you would always need to provide your own execute method, while it could be perfectly fine to use the normal execute method.

[wadissimo]

Why? That way you would always need to provide your own execute method, while it could be perfectly fine to use the normal execute method.

It said in JavaDocs:
"This class is abstract and it is intended that subclasses will provide a typed method for invocation that delegates to the supplied execute(java.util.Map) method."
I believe it is how StoredProcedure used.
The need to provide execute method doesnt' depend on whether it is protected or public. Even more if it is protected you should provide it otherwise clients whould have no methods to invoke.

[Marten Deinum]

Hmm we have quite some classes which extend the StoredProcedure class, we use it with the supplied execute method. If the method would become protected, we would need to rewrite part of our application.

[wadissimo]

But now we need to always use super.execute() and override execute() and throw RuntimeException from it.=(

[Marten Deinum]

But now we need to always use super.execute() and override execute() and throw RuntimeException from it.=(

Why? If I have an instance of StoredProcedure (be it an extension or anonymous inner class) I can simply call execute and pass in a map.

[wadissimo]

I understand ur point. But we don't need to expose this method.