After advice never called.

[incubator]

Hi,

I have the following advice:

@Aspect
public class PictureUpdateAspect {
	
	@After("execution(public void dao.PictureDao.*(model.Picture)) and this(picture)")
	public void onPictureAddDelete(Picture picture) {
		System.out.println("test");
	}
}

and that should be executed after the following methods:

package dao;

public class PictureDao {
      public void save(Picture picture) {}
      public void delete(Picture picture) {}
}

in my XML config I have the following:

<bean id="pictureUpdateAspect" class="aspects.PictureUpdateAspect" />
<aop:aspectj-autoproxy />

But for some reason my aspect's method is never called.
Is there anything I forgot?

[Mark Fisher]

Change 'this(picture)' to 'args(picture)'.

When binding 'this' context, it refers to the proxy itself (in this case the proxied DAO object). You want to bind the Picture-typed argument there instead.

[incubator]

I tried that too but it didnt work.
I figured out why though.
The PictureDao class extends from BaseDao<T, PK extends Serialisable>.

and I read somewhere in here that Spring 2.0.6 with AspectJ seems to have difficulties with generics.
When I tried this on a method on a different class (all non-generics) it worked fine.