List and ComboBoxBinder.COMPARATOR_KEY

[Manus]

Hello,

The SwingBindingFactory is creating BoundComboBox and BoundList with inverse order of elements.
I'm a bit confused but I think the constructor of PropertyComparator is inverting the idea of ascending/descending.

If PropertyComparator is right, wouldn't be better to create the List and Combo with elements in descending order (from A to Z)?

    public Binding createBoundComboBox(String formProperty,
        ValueModel selectableItemsHolder, String renderedProperty)
    {
        Map context = createContext(ComboBoxBinder.SELECTABLE_ITEMS_KEY,
            selectableItemsHolder);
        //ommited
        context.put(ComboBoxBinder.COMPARATOR_KEY, new PropertyComparator(
            renderedProperty, true, true)); //previously false
        return createBinding(JComboBox.class, formProperty, context);
    }

    public Binding createBoundList(String selectionFormProperty,
        Object selectableItems, String renderedProperty, Integer forceSelectMode)
    {
        final Map context = new HashMap();
        //ommited
        if (renderedProperty != null)
        {
            context.put(ListBinder.RENDERER_KEY,
                new BeanPropertyValueListRenderer(renderedProperty));
            context.put(ListBinder.COMPARATOR_KEY, new PropertyComparator(
                renderedProperty, true, true)); //previously false
        }
        //ommited
    }

Thanks,

Mauro.

[Mathias Broekelmann]

Thanks for the hint. I've fixed this.

[Manus]

Hi Mathias,

Thanks for the quick fixes!
Could you please take a lot at http://forum.springframework.org/showthread.php?t=28656 ?
Some tip about it?

Thanks,

Mauro.