Advice not used .. what is wrong? pleas help me :)

[BADJAN]

Hi,

I am trying to get AOP to work, but didn’t had success yet.
It’s just about a simple logging example.

I would like to get a simple logging message for each execution of a method in “ProjectManagementService� class.

Unfortunately nothing happens, but there is also no error message.

Pleas help me . What am I doing wrong?

Jan

Created the Advice:

public class ProjectManagementLoggingAdvice implements MethodBeforeAdvice {
	
	public void before(Method method, Object[] args, Object target){
		System.out.println("Servicemethod "+method.getName().toString()+" called!");
	}

}

Configuring the applicationContext:

<!-- AOP Beans &#58;&#58; start &#58;&#58; -->
	
	<bean id="debugInterceptor" class="org.springframework.aop.interceptor.DebugInterceptor" />
		
	<bean id="ProjectServiceProxy" class="org.springframework.aop.framework.ProxyFactoryBean">		
		<property name="proxyTargetClass">
			<value>true</value>
		</property>
		<property name="optimize">
			<value>true</value>
		</property>
		<property name="target">
			<ref bean="ProjectManagementService"/>
		</property>
		<property name="interceptorNames">	
			<list>	
				<value>ProjectManagementLoggingAdvice</value>
				<value>debugInterceptor</value>				
			</list>
		</property>
	</bean>			
	
	<bean id="ProjectManagementLoggingAdvice" class="de.adtech.swd.modules.aop.ProjectManagementLoggingAdvice" />
	
	<!-- AOP Beans &#58;&#58; end &#58;&#58; --> 
			 
	<!--  ProjectManangement &#58;&#58; start &#58;&#58;  --> 
	 <bean id="ProjectManagementController" class="de.adtech.swd.frontcontroller.ProjectManagementController">
    	<property name="projectms">
            <ref bean="ProjectManagementService"/>
        </property>       
    </bean>	
	
	<bean id="ProjectManagementService" class="de.adtech.swd.model.services.ProjectManagementService" singleton="true">       
    	<property name="projectBDao">
    		<ref bean="ProjectManagementDao"/>
    	</property> 
    	<property name="mediator">
    		<ref bean="ProjectManagementMediator"/>
    	</property>
    </bean>

Do actions in Controller:

public class ProjectManagementController implements Controller {
	
	private ProjectManagementService projectms;
	
	public ModelAndView handleRequest(HttpServletRequest arg0, HttpServletResponse arg1) throws Exception {
				 
		//fill all needed beans for jsf view
		projectms.fillProjectBeanList();
		projectms.fillCustomerBeanList();
		//create selectItems for jsf view
		List customers = projectms.getCustomerBeanList();
		projectms.generateSelectItemsOfCustomers(customers);			
						
		return new ModelAndView("projectmanagement_list");
	}
	
	public void setProjectms(ProjectManagementService pms) {
		this.projectms = pms;
	}

}

Do I have to get Access to the ProjectManagementService by using something like :

 ApplicationContext ctx = new   FileSystemXmlApplicationContext(configFile);
…ctx.getBean("ProjectManagementService");

to be able to use Spring AOP ? (I hope not)

[katentim]

You're inserting the service instead of the proxy.

Change:

    <bean id="ProjectManagementController" class="de.adtech.swd.frontcontroller.ProjectManagementController">
       <property name="projectms">
            <ref bean="ProjectManagementService"/>
        </property>       
    </bean>

to

    <bean id="ProjectManagementController" class="de.adtech.swd.frontcontroller.ProjectManagementController">
       <property name="projectms">
            <ref bean="ProjectServiceProxy"/>
        </property>       
    </bean>

[BADJAN]

Yes, that's it .
It works without problems.
Thank you very very much

Jan

[katentim]

No problemo.