Accessing the TargetSource from a MethodInterceptor

[Ryan.Stone]

Is there any way to access the TargetSource for a proxied object within the interceptor? In my case, I want to change the target object with a HotSwappableTargetSource:

public class AnInterceptor implements MethodInterceptor  {
    public Object invoke(MethodInvocation methodInvocation) throws Throwable {
        Advised bean = (Advised) something;//where do I get the advised object?
        HotSwappableTargetSource source = (HotSwappableTargetSource) bean.getTargetSource();
        source.swap(somethingElse);
         ...
}

methodInvocation.getThis() isn't returning the proxy, but the advised object, and I can't figure out where else I could possibly access the proxy. Any ideas? Or I am going about this the wrong way?

[Andreas Senft]

Maybe http://forum.springframework.org/showthread.php?t=17039 might help you.

Regards,
Andreas

[Ryan.Stone]

Maybe http://forum.springframework.org/showthread.php?t=17039 might help you.

Regards,
Andreas

Unfortunately, I don't seem to have access to the proxy, only the target itself.

[wpoitras]

How about this blog entry

[Ryan.Stone]

Ah, that's a good idea. He's configured Spring to directly provide the Target Source to the Interceptor via IoC. Now, in my case, the target is not a singleton, so I'd imagine that my target source can't be a singleton, either. How do I ensure that each interceptor gets a reference to the target source used by the proxied object?

<bean id="aProxy" class="org.springframework.aop.framework.ProxyFactoryBean">
        <property name="targetSource" ref="swapper"/>
        <property name="singleton">
            <value>false</value>
        </property>
        <property name="interceptorNames">
            <list>
                <value>anInterceptor</value>
            </list>
        </property>
    </bean>

    <bean id="swapper" class="org.springframework.aop.target.HotSwappableTargetSource" singleton="false">
        <constructor-arg>
            <bean class="path.to.advised.class" singleton="false"/>
        </constructor-arg>
    </bean>

    <bean id="anInterceptor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
        <constructor-arg>
            <bean class="path.to.Pointcut"/>
        </constructor-arg>
        <constructor-arg>
            <bean class="path.to.AnInterceptor">
                <property name="targetSource">
                    <ref bean="swapper"/>
                </property>
            </bean>
        </constructor-arg>
    </bean>

Edit: Sorry, didn't finish my thought before posting. If I configure things as above, the Interceptor will get a different target source from the proxy, because the target source isn't a singleton. However, if I were to make the target source a singleton, then all of my proxies would share the same target, whichs mean I could only proxy one instance of the advised class. So, how can I ensure that each proxy gets a unique target source, while ensure that each interceptor gets the same target source as its proxy?

[robh]

You can get the current proxy for the advised invocation by calling AopContext.currentProxy. The proxy object can then be cast to an instance of Advised and from there you can retreive the TargetSource using getTargetSource().

Rob

[Ryan.Stone]

Ok, that worked, thanks, but there is a small problem. The swap doesn't take effect for the current method invocation, only the subsequent ones(in other words, when I call methodInvocation.proceed() after swapping the target, the method is still called on the old target, not the new one). I can get around this by doing:

methodInvocation.getMethod().invoke(newTarget, methodInvocation.getArguments());

instead of methodInvocation.proceed(). I only have the one interceptor, so everything will work properly in this case, but it would be nice to know if there was a way to have methodInvocation.proceed() act on the new target after swapping.

[robh]

Mmm, so what you are saying is that you swap the target in the interceptor, but for the whole of that invocation that swap is not active?

Can you post a feature request for this on JIRA along with a test to highlight it?
Rob

[Ryan.Stone]

I will post that JIRA request as soon as I get some time to write a test case. In the meantime, I've found a slightly better solution to the problem than

methodInvocation.getMethod().invoke(newTarget, methodInvocation.getArguments());

is

methodInvocation.getMethod().invoke(proxy, methodInvocation.getArguments());

In the first case, interceptors in the chain after the swapping interceptor will not be executed. In the second case, interceptors in the chain before the swapping interceptor(including the swapping intercetor) will be executed twice, but the interceptors after the swapping interceptor will be executed.

[ricvilla]

In your last response, you changed newTarget to proxy (in order to avoid the last problem described, which I am also facing). How do you set the proxy Object? Thanks!