Exception handling with transaction AOP

[bgonline]

Hello,

I have the follownig configuration in my springConfig.xml file :

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http&#58;//www.springframework.org/dtd/spring-beans.dtd">

<beans>	
	<!-- ========================= Start of PERSISTENCE DEFINITIONS ========================= -->
	<!-- DataSource Definition -->
	<bean id="dataSource"
      		class="org.apache.commons.dbcp.BasicDataSource" destroy-method="close">
		<property name="driverClassName">
			<value>oracle.jdbc.driver.OracleDriver</value>
		</property>
		<property name="url">
			<value>URL</value>
		</property>
		<property name="username">
			<value>USERNAME</value>
		</property>
		<property name="password">
			<value>PASSWORD</value>
		</property>
	</bean>
	
	<!-- Hibernate SessionFactory Definition -->
	<bean id="sessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
		<property name="mappingResources">
			<list>
				<value>MAPPING_RESOURCES</value>
			</list>
		</property>		
		<property name="hibernateProperties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.Oracle9Dialect</prop>
				<prop key="hibernate.show_sql">true</prop>
				<prop key="hibernate.cglib.use_reflection_optimizer">true</prop>
				<prop key="hibernate.cache.provider_class">org.hibernate.cache.HashtableCacheProvider</prop>
			</props>
		</property>	
		<property name="dataSource">
			<ref bean="dataSource"/>
		</property>
	</bean>
	
	<!-- Spring Data Access Exception Translator Defintion -->
	<bean id="jdbcExceptionTranslator" class="org.springframework.jdbc.support.SQLErrorCodeSQLExceptionTranslator"> 
		<property name="dataSource"><ref bean="dataSource"/></property> 
	</bean>

	<!-- Hibernate Template Defintion -->
	<bean id="hibernateTemplate" class="org.springframework.orm.hibernate3.HibernateTemplate">
		<property name="sessionFactory"><ref bean="sessionFactory"/></property> 
		<property name="jdbcExceptionTranslator"><ref bean="jdbcExceptionTranslator"/></property> 
	</bean>
	
	<!-- ErrMsg DAO object&#58; Hibernate implementation -->
	<bean id="errMsgDao" class="ErrMsgDAOHibernateImpl">
		<property name="hibernateTemplate"><ref bean="hibernateTemplate"/></property>
	</bean>
	
	<!-- ========================= Start of SERVICE DEFINITIONS ========================= -->
	
	<!-- Hibernate Transaction Manager Definition -->
	<bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">
		<property name="sessionFactory"><ref local="sessionFactory"/></property>
	</bean>
	
	<!-- ErrrorMessage Service Defintion -->
	<bean id="errorMessageServiceTarget"
			class="ErrorMessageServiceHibernateImpl">
		<property name="errMsgDao"><ref local="errMsgDao"/></property>
	</bean>
	
	<!-- Transactional proxy for the ErrrorMessage Service -->
	<bean id="errorMessageService"
			class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
		<property name="transactionManager"><ref local="transactionManager"/></property>
		<property name="target"><ref local="errorMessageServiceTarget"/></property>
		<property name="transactionAttributes">
			<props>
				<prop key="find*">PROPAGATION_REQUIRED,readOnly</prop>
				<prop key="save*">PROPAGATION_REQUIRED</prop>
				<prop key="update*">PROPAGATION_REQUIRED</prop>
				<prop key="delete*">PROPAGATION_REQUIRED</prop>
			</props>
		</property>
	</bean>
</beans>

And in my ErrorMessageServiceHibernateImpl, I have the following code :

public void update(Cwd01 errMsg) throws Exception {
	try {
		this.getErrMsgDao().updateErrMsg(errMsg);
	} catch(DataIntegrityViolationException dive) {
		throw dive;
	} catch (Exception e) {
		throw e
	}
}

But when I make an update with a field too large (I try to set a 300 characters String in a 250 database field), I don't go into the DataIntegerityViolationException of my business service, but well in my JSF-bean that has called this service.

How is it possible ?

I have the following error :

org.springframework.dao.DataIntegrityViolationException: (Hibernate operation: Could not execute JDBC batch update): data integrity violated by SQL 'update CWD01 set NUMVER=?, REFMAJ=?, DATCRT=?, DATMAJ=?, HEUMAJ=?, USRMAJ=?, PGMMAJ=?, STAANN=?, LIBMSG_1=?, LIBMSG_2=?, LIBMSG_3=?, LIBMSG_4=?, NUMREF=?, SWIAUD=? where NUMMSG=?'; nested exception is java.sql.BatchUpdateException: ORA-01401: inserted value too large for column

java.sql.BatchUpdateException: ORA-01401: inserted value too large for column

	at oracle.jdbc.dbaccess.DBError.throwBatchUpdateException(DBError.java:430)
	at oracle.jdbc.driver.OraclePreparedStatement.executeBatch(OraclePreparedStatement.java:2948)
	at org.apache.commons.dbcp.DelegatingPreparedStatement.executeBatch(DelegatingPreparedStatement.java:231)
	at org.hibernate.jdbc.BatchingBatcher.doExecuteBatch(BatchingBatcher.java:57)
	at org.hibernate.jdbc.AbstractBatcher.executeBatch(AbstractBatcher.java:174)
	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:226)
	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:137)
	at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:274)
	at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
	at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:730)
	at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:324)
	at org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:86)
	at org.springframework.orm.hibernate3.HibernateTransactionManager.doCommit(HibernateTransactionManager.java:488)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:435)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.doCommitTransactionAfterReturning(TransactionAspectSupport.java:258)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:67)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:144)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:174)
	at $Proxy56.update(Unknown Source)
	at com.cwsoft.emmngt.view.bean.ErrorMessageBean.updateConfirm(ErrorMessageBean.java:194)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at com.sun.faces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:126)
	at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:72)
	at javax.faces.component.UICommand.broadcast(UICommand.java:312)
	at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:266)
	at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:380)
	at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:75)
	at com.sun.faces.lifecycle.LifecycleImpl.phase(LifecycleImpl.java:200)
	at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:90)
	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
	at org.extremecomponents.table.filter.ExportFilter.doFilter(ExportFilter.java:87)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
	at com.cwsoft.commons.webapp.filter.SecurityFilter.doFilter(SecurityFilter.java:66)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
	at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:75)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
	at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
	at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
	at org.jboss.web.tomcat.security.CustomPrincipalValve.invoke(CustomPrincipalValve.java:66)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
	at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:150)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
	at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:54)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
	at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
	at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
	at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
	at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
	at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705)
	at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577)
	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683)
	at java.lang.Thread.run(Thread.java:534)

Thanks in advance for your help.
Blaise

[Andreas Senft]

As you can see from the stacktrace, the exception is not being thrown on the update operation but on the commit. But the commit is invoked after your update()-Method has been left; too late to catch the exception there.

Maybe it helps, if you perform a flush() inside your hibernate DAO, to force this error to occur earlier.

Regards,
Andreas

[bgonline]

First of all, thanks for your reply.

But could you explain me why the exception occures during the commit, and not during the update ? The update should normaly already create an exception. Am I wrong ?

And could you also explain me what to do to perform a flush inside the Hibernate DAO ? I don't understand it !?

Thanks in advance...

[Andreas Senft]

Hibernate (as other ORM libraries) does not necessarily issue SQL to the database the moment you fire an update query. It might be that it waits until before commit to issue all SQL operations in a bunch. This is happening here.

Note that delaying the actual SQL generation might be used for optimizing database load. For example, you might change an instance and then delete it a little bit later (in the same transaction). No need to perform an UPDATE, the DELETE alone would be just fine.

The hibernate Session has a flush() method which is by default automatically invoked before commit (can be adjusted though). This method takes care that any outstanding operations are actually sent to the database. If you invoke flush() inside your DAO method (so inside your catch block) you might be able to catch the exception in the place you expect.

Just be aware that there still might be some other constraints that will be checked only at commit time. So it is no guarantee that a successful flush will lead to a successful commit.

Regards,
Andreas