Simple Interception

[belaran]

Hi everyone,

I tried to realize a very simple interception. My interceptor bean is created
but my interceptor is never call. I want to intercept , with a before advice method, any to call to

void onClickOnPushMe(ActionEvent e) 
void setText(String text)

My regex pattern is :

<value>.*setText*</value>
<value>.*onClickOnPushMe*</value>

but it failed to do the trick.

I add my config.xml's file just below with my interceptor code wich is pretty hallow.

<bean id="textInterceptor" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
        <property name="advice" ref="userInterceptorImpl"/>
        <property name="patterns">
            <list>
                <value>.*setText*</value> 
            	<value>.*onClickOnPushMe*</value>
            </list>
        </property>
    </bean> 
	<bean id="userInterceptorImpl" class="com.AO.SpringAppContext.app.TextInterceptor"/>

public class TextInterceptor implements MethodBeforeAdvice
{
	private static Logger _log = Logger.getLogger("INTERCEPTOR:");
	public TextInterceptor()
	{
		_log.info("Creating UserInterceptor");
	}
	public void before(Method arg0, Object[] arg1, Object arg2) throws Throwable 
	{
		_log.info("INTERCEPTION !");
	}
}

Thanks !

[Andreas Senft]

My regex pattern is :

<value>.*setText*</value>
<value>.*onClickOnPushMe*</value>

but it failed to do the trick.

Try this:

.*?setText.*
.*?onClickOnPushMe.*

Regards,
Andreas

[belaran]

That failed too... There must something wrong...

My spring core build the following beans :

<bean id="gui" class="com.AO.SpringAppContext.GUI.HelloWorldClass" autowire="byType"/>
	<bean id="Treatement" class="com.AO.SpringAppContext.bus.Treatement"/>

"gui" has a method setText and Treatement has a method doJob, so the following pattern should work :

 <list>
<value>.*?setText.*</value> 
<value>.*onClickOnPushMe</value>
<value>.*doJob.*</value>
</list>

[Andreas Senft]

Maybe you should provide the full configuration of the beans. For example the ProxyFactoryBean proxying your bean would be interesting.

Regards,
Andreas

[belaran]

Okay.

I used AppContext to build my beans :

public static void main(String[] args) 
	{
		ApplicationContext cxt = new   FileSystemXmlApplicationContext(configFile);
		IGUI winApp = (IGUI) cxt.getBean("gui");
		winApp.setCtx(cxt);
                winApp.setText(cxt.getMessage("NewText",null,"NoBundle",null));
	}

As specified, my interceptor should be triggered when winApp.setText(...) is called.

My config.xml :

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http&#58;//www.springframework.org/dtd/spring-beans.dtd">
<beans>
	<bean id="gui" class="com.AO.SpringAppContext.GUI.HelloWorldClass" autowire="byType"/>
	<bean id="Treatement" class="com.AO.SpringAppContext.bus.Treatement"/>
	<bean id="messageSource" class="org.springframework.context.support.ResourceBundleMessageSource">
		<property name="basenames">
			<list>
				<value>AO</value>
			</list>
		</property>
	</bean>	
	<bean id="textInterceptor" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
        <property name="advice" ref="userInterceptorImpl"/>
        <property name="patterns">
            <list>
                <value>.*?setText.*</value> 
            	<value>.*onClickOnPushMe</value>
            	<value>.*doJob.*</value>
            </list>
        </property>
    </bean> 
	<bean id="userInterceptorImpl" class="com.AO.SpringAppContext.app.TextInterceptor"/>
</beans>

That's everything that seemed meaningfull.
Thanks for any help you can provide...

[Andreas Senft]

In fact I cannot see, why the interceptor should kick in, when you access your bean.

You have to specify a ProxyFactoryBean that creates a proxy with your bean as target and your interceptor inbetween.

See the reference for details

Regards,
Andreas

[belaran]

Ok.

To realize an interception i should have done this:

<beans>
        <!-- my simple an naive bean, unaware of the fact that it's going to be intercepted. -->
	<bean id="guiImpl" class="com.AO.SpringAppContext.GUI.HelloWorldClass" autowire="byType"/>

	<!--Proxying the simple and naive bean -->
	<bean id="gui" class="org.springframework.aop.framework.ProxyFactoryBean">
    	<property name="proxyInterfaces"><value>com.AO.SpringAppContext.GUI.IGUI</value></property>
    	<property name="target"><ref local="guiImpl"/></property>
    	<property name="interceptorNames">
    	    <list>
    	        <value>userInterceptorImpl</value>
    	    </list>
    	</property>
	</bean>
        <!-- The interceptor class -->
	<bean id="userInterceptorImpl" class="com.AO.SpringAppContext.app.TextInterceptor"/>
</beans>

I've done this and i worked perfectly. No i realize my problem was lexical.
Actually, i wanted to advice my app, so i used the xml code specified above...
Now I'm going to try to make the code above work. If i run into any trouble i should create a new post entitled "Simple Advice"

Thanks for uour help...