Cannot catch ObjectNotFoundException in Spring 1.2.2

[yfmoan]

Hi , l migrating my application from (hibernate2.1 + Spring 1.2.1) to (hibernate3 + Spring 1.2.2) , meet problem in catching "org.hibernate.ObjectNotFoundException" , l cannot catch the ObjectNotFoundException using the following code ,

try {
              publisher = getLibrary().loadPublisher(RequestUtils.getLongParameter(request,"id",0));
}catch(org.springframework.orm.ObjectRetrievalFailureException orfe){
              return new Publisher();
}

It used to work in hibernate2.1 + Spring 1.2.1.

The error message ,

2005-07-24 16:14:29,898 INFO [org.hibernate.event.def.DefaultLoadEventListener] - <Error performing load command>
org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.yourschool.library.domain.Publisher#0]
at org.hibernate.ObjectNotFoundException.throwIfNull( ObjectNotFoundException.java:27)
at org.hibernate.event.def.DefaultLoadEventListener.l oad(DefaultLoadEventListener.java:118)
at org.hibernate.event.def.DefaultLoadEventListener.o nLoad(DefaultLoadEventListener.java:75)
at org.hibernate.impl.SessionImpl.immediateLoad(Sessi onImpl.java:643)
at org.hibernate.proxy.AbstractLazyInitializer.initia lize(AbstractLazyInitializer.java:59)
at org.hibernate.proxy.AbstractLazyInitializer.getImp lementation(AbstractLazyInitializer.java:84)
at org.hibernate.proxy.CGLIBLazyInitializer.intercept (CGLIBLazyInitializer.java:134)
at org.yourschool.library.domain.Publisher$$EnhancerB yCGLIB$$78e39465.toString(<generated>)
at java.lang.String.valueOf(Unknown Source)
at java.lang.StringBuffer.append(Unknown Source)
at org.yourschool.library.web.PublisherForm.formBacki ngObject(PublisherForm.java:35)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.getErrorsForNewForm(AbstractFormControlle r.java:325)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.showNewForm(AbstractFormController.java:3 06)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.handleRequestInternal(AbstractFormControl ler.java:248)
at org.springframework.web.servlet.mvc.AbstractContro ller.handleRequest(AbstractController.java:128)
at org.springframework.web.servlet.mvc.SimpleControll erHandlerAdapter.handle(SimpleControllerHandlerAda pter.java:44)
at org.springframework.web.servlet.DispatcherServlet. doDispatch(DispatcherServlet.java:684)
at org.springframework.web.servlet.DispatcherServlet. doService(DispatcherServlet.java:625)
at org.springframework.web.servlet.FrameworkServlet.s erviceWrapper(FrameworkServlet.java:386)
at org.springframework.web.servlet.FrameworkServlet.d oGet(FrameworkServlet.java:346)
at javax.servlet.http.HttpServlet.service(HttpServlet .java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet .java:802)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:237)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.springframework.orm.hibernate3.support.OpenSes sionInViewFilter.doFilterInternal(OpenSessionInVie wFilter.java:172)
at org.springframework.web.filter.OncePerRequestFilte r.doFilter(OncePerRequestFilter.java:76)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at com.opensymphony.module.sitemesh.filter.PageFilter .parsePage(PageFilter.java:118)
at com.opensymphony.module.sitemesh.filter.PageFilter .doFilter(PageFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.yourschool.library.web.filter.ExceptionFilter. doFilter(ExceptionFilter.java:48)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.yourschool.library.web.filter.EncodingFilter.d oFilter(EncodingFilter.java:43)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.apache.catalina.core.StandardWrapperValve.invo ke(StandardWrapperValve.java:214)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardContextValve.invo keInternal(StandardContextValve.java:198)
at org.apache.catalina.core.StandardContextValve.invo ke(StandardContextValve.java:152)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardHostValve.invoke( StandardHostValve.java:137)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:118)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:102)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardEngineValve.invok e(StandardEngineValve.java:109)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.ContainerBase.invoke(Cont ainerBase.java:929)
at org.apache.coyote.tomcat5.CoyoteAdapter.service(Co yoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(H ttp11Processor.java:799)
at org.apache.coyote.http11.Http11Protocol$Http11Conn ectionHandler.processConnection(Http11Protocol.jav a:705)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(P oolTcpEndpoint.java:577)
at org.apache.tomcat.util.threads.ThreadPool$ControlR unnable.run(ThreadPool.java:683)
at java.lang.Thread.run(Unknown Source)
2005-07-24 16:14:29,928 WARN [org.springframework.web.servlet.DispatcherServlet] - <Handler execution resulted in exception - forwarding to resolved error view>
org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.yourschool.library.domain.Publisher#0]
at org.hibernate.ObjectNotFoundException.throwIfNull( ObjectNotFoundException.java:27)
at org.hibernate.event.def.DefaultLoadEventListener.l oad(DefaultLoadEventListener.java:118)
at org.hibernate.event.def.DefaultLoadEventListener.o nLoad(DefaultLoadEventListener.java:75)
at org.hibernate.impl.SessionImpl.immediateLoad(Sessi onImpl.java:643)
at org.hibernate.proxy.AbstractLazyInitializer.initia lize(AbstractLazyInitializer.java:59)
at org.hibernate.proxy.AbstractLazyInitializer.getImp lementation(AbstractLazyInitializer.java:84)
at org.hibernate.proxy.CGLIBLazyInitializer.intercept (CGLIBLazyInitializer.java:134)
at org.yourschool.library.domain.Publisher$$EnhancerB yCGLIB$$78e39465.toString(<generated>)
at java.lang.String.valueOf(Unknown Source)
at java.lang.StringBuffer.append(Unknown Source)
at org.yourschool.library.web.PublisherForm.formBacki ngObject(PublisherForm.java:35)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.getErrorsForNewForm(AbstractFormControlle r.java:325)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.showNewForm(AbstractFormController.java:3 06)
at org.springframework.web.servlet.mvc.AbstractFormCo ntroller.handleRequestInternal(AbstractFormControl ler.java:248)
at org.springframework.web.servlet.mvc.AbstractContro ller.handleRequest(AbstractController.java:128)
at org.springframework.web.servlet.mvc.SimpleControll erHandlerAdapter.handle(SimpleControllerHandlerAda pter.java:44)
at org.springframework.web.servlet.DispatcherServlet. doDispatch(DispatcherServlet.java:684)
at org.springframework.web.servlet.DispatcherServlet. doService(DispatcherServlet.java:625)
at org.springframework.web.servlet.FrameworkServlet.s erviceWrapper(FrameworkServlet.java:386)
at org.springframework.web.servlet.FrameworkServlet.d oGet(FrameworkServlet.java:346)
at javax.servlet.http.HttpServlet.service(HttpServlet .java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet .java:802)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:237)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.springframework.orm.hibernate3.support.OpenSes sionInViewFilter.doFilterInternal(OpenSessionInVie wFilter.java:172)
at org.springframework.web.filter.OncePerRequestFilte r.doFilter(OncePerRequestFilter.java:76)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at com.opensymphony.module.sitemesh.filter.PageFilter .parsePage(PageFilter.java:118)
at com.opensymphony.module.sitemesh.filter.PageFilter .doFilter(PageFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.yourschool.library.web.filter.ExceptionFilter. doFilter(ExceptionFilter.java:48)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.yourschool.library.web.filter.EncodingFilter.d oFilter(EncodingFilter.java:43)
at org.apache.catalina.core.ApplicationFilterChain.in ternalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.do Filter(ApplicationFilterChain.java:157)
at org.apache.catalina.core.StandardWrapperValve.invo ke(StandardWrapperValve.java:214)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardContextValve.invo keInternal(StandardContextValve.java:198)
at org.apache.catalina.core.StandardContextValve.invo ke(StandardContextValve.java:152)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardHostValve.invoke( StandardHostValve.java:137)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:118)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:102)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.StandardEngineValve.invok e(StandardEngineValve.java:109)
at org.apache.catalina.core.StandardValveContext.invo keNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(S tandardPipeline.java:520)
at org.apache.catalina.core.ContainerBase.invoke(Cont ainerBase.java:929)
at org.apache.coyote.tomcat5.CoyoteAdapter.service(Co yoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(H ttp11Processor.java:799)
at org.apache.coyote.http11.Http11Protocol$Http11Conn ectionHandler.processConnection(Http11Protocol.jav a:705)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(P oolTcpEndpoint.java:577)
at org.apache.tomcat.util.threads.ThreadPool$ControlR unnable.run(ThreadPool.java:683)
at java.lang.Thread.run(Unknown Source)

is that my problem ? Thanks

moon

[yfmoan]

The above "org.hibernate.ObjectNotFoundException" are from formBackingObject() , but it is so strange that it did not happen in PublisherDelete.java , it can be catch in PublisherDelete's handleRequestInternal(..).

PublisherForm.java,

public class PublisherForm extends AbstractLibraryFormController {

	public PublisherForm() {
	       	setCommandClass(Publisher.class);
	       	setCommandName("publisher");
	       	// activate session form mode to allow for detection of duplicate submissions
	       	setSessionForm(true);
	       	//setBindOnNewForm(true);
	}

	/** Method forms a copy of an existing Publisher for editing */
	protected Object formBackingObject(HttpServletRequest request) throws ServletException {

                Publisher publisher = null;
                //System.out.println("******|||||||||*******");
                try {
                        publisher = getLibrary().loadPublisher(RequestUtils.getLongParameter(request,"id",0));
                        //System.out.println("+++++++"+publisher+"+++++++");
                }catch(org.springframework.orm.ObjectRetrievalFailureException orfe){
                        //System.out.println("+++++++"+orfe+"+++++++");
                        return new Publisher();
                }

                return publisher;

	}

        public ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse response, Object command, BindException errors)
		throws Exception {

		Publisher publisher = (Publisher) command;
                Long id = publisher.getId();

                // (id == null) == "Add" action , otherwise "Edit" action
		try{
		   	getLibrary().storePublisher(publisher);

                        if(id == null) {
                                writeMessage(request,"message_publisher_added","publisher.added",
                                        new Object[] {publisher.getPublisherName()});
                                request.getSession().setAttribute("addedPublisher",publisher);
                        }else {
                        		writeMessage(request,"message_publisher_edited","publisher.edited",
                                        new Object[] {publisher.getPublisherName()});
                                request.getSession().setAttribute("editedPublisher",publisher);
                        }
		}
                catch(DataIntegrityViolationException eive){

                        // errors.rejectValue(x,y,z) - z just a default , if found no y ,
                        // then display z , it will lose i18n if show z.
                        errors.rejectValue("publisherName", "publisher.name.already.exists",
                                           "Publisher Name already exists ...");
			return showForm(request, response, errors);

		}catch(ObjectOptimisticLockingFailureException eoolfe){
		        errors.rejectValue("publisherName", "publisher.name.already.updated.or.deleted",
                                           "The Publisher Name have been updated or deleted by other user...");

                        return showForm(request, response, errors);
		}

                if(id == null)  return  new ModelAndView(new RedirectView(getSuccessAddView()));

                return new ModelAndView(new RedirectView(getSuccessEditView()),makePagingCommandMap(request,getActionName()));

        }

}

PublisherDelete.java

public class PublisherDelete extends AbstractLibraryController {

	public ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response)
               throws Exception {

               try{
                   
                   Publisher publisher = getLibrary().loadPublisher(RequestUtils.getLongParameter(request,"id",0));

                   getLibrary().deletePublisher(RequestUtils.getLongParameter(request,"id",0));

                   writeMessage(request,"message_publisher_deleted","publisher.deleted",
                                        new Object[] {publisher.getPublisherName()});

               }catch (org.springframework.orm.ObjectRetrievalFailureException orfe){
                                                                                    	
                   System.out.println("@@@@@"+orfe+"@@@@@");
                   return new ModelAndView(new RedirectView(getSuccessView()), makePagingCommandMap(request,getActionName()));
              }

              return new ModelAndView(new RedirectView(getSuccessView()), makePagingCommandMap(request,getActionName()));
        }

}

there is an OpenSessionInViewFilter for this two controller to avoid org.hibernate.LazyInitializationException in hibernate3 .
Any body met this problem b4 ?

moon

[yfmoan]

Default setting for class's lazy attribute in xxx.hbm.xml in Hibernate2 was false , but hibernate3 change the default to true,
Code cause problem:

<class name="org.yourschool.library.domain.Publisher"
	table="PUBLISHERS" >

have to change it to in hibernate3

<class name="org.yourschool.library.domain.Publisher"
	table="PUBLISHERS" lazy="false">

then the problem solved (even without the OpenSessionInViewFilter).

But l still don't understand ... why we cannot catch a lazy loading class ?, can somebody help me to understand this behaviour ..thanks in advance.

moon

[Juergen Hoeller]

I guess the reason for the behavior you're experiencing is Hibernate's lazy loading for classes: A "load" call is not necessarily actually loading the instance. It might rather expose a proxy to you that won't load its data until you touch the corresponding fields. As a consequence, the actual check for existence will happen lazily as well...

Juergen

[yfmoan]

Hi Juergen, thanks for your answer ,

yes , l have thought this answer too , but the strange thing is , l can catch it using org.hibernate.ObjectNotFoundException instead of org.springframework.orm.ObjectRetrievalFailureExce ption ... why ?

haha ...still don't understand ...

moon

[Juergen Hoeller]

Hibernate does not initialize your object before you touch any method other than the id accessor. In your case, that is the "toString" method that you implicitly call in your "formBackingObject" implementation, through the printing to the console. This already happens outside the Spring DAO, so now exception conversion takes place - hence, you get the raw Hibernate exception.

I would recommend to switch Hibernate's lazy loading off - at least at the class level.

Juergen

[yfmoan]

Yes , you are right.

Actually l cannot catch the org.hibernate.ObjectNotFoundException if comment out the system printout.

System.out.println("+++++++"+publisher+"+++++++");

In the original code l did this

try { 
      publisher = getLibrary().loadPublisher(RequestUtils.getLongParameter(request,"id",0));
      System.out.println("+++++++"+publisher+"+++++++"); 
}catch(org.springframework.orm.ObjectRetrievalFailureException orfe){ 
      return new Publisher(); 
}

To summarize , if

1. lazy="true"

<class name="org.yourschool.library.domain.Publisher" 
   table="PUBLISHERS" lazy="true">

2. with comment

System.out.println("+++++++"+publisher+"+++++++");

3. with OpenSessionInViewFilter

Result : org.hibernate.ObjectNotFoundException will be throw by H3 (error message in the first post)
and this is not cause by

publisher = getLibrary().loadPublisher(RequestUtils.getLongParameter(request,"id",0));

but

System.out.println("+++++++"+publisher+"+++++++");

and this is out of bound of spring DAO , so no exception conversion take place , l got a raw Hibernate exception.

so now exception conversion takes place - hence, you get the raw Hibernate exception

Is that a mistype ?

Thanks ..once again .....because it is not easy for me to see the answer, system printout is a foreigner for me , l never thought it can affect the code in PublisherForm.java.

moon