PerformanceMonitorInceptor

[chenrici]

i want to monitor different implementations of the same interface.
using the PerformanceMonitorInterceptor i am getting"only" the name of Interface logged.
Is it in any way possible to get the name of the implementing class?

best thanx for any advice.
Christoph

[robh]

Christoph,

Can you post the configuration you are using to define the monitored proxies along with snippets of code for the objects being proxied.

Rob

[chenrici]

Rob,

here a snippet from my configuration:

<bean id="rabattDao" class="com.apgsga.vk.preisermittlung.db.RabattDaoImpl">
		<property name="dataSource">
			<ref local="dataSource"/>
		</property>
	</bean>
	<bean id="monitoredrabattDao" 
		class="org.springframework.aop.framework.ProxyFactoryBean">
		<property name="proxyInterfaces">
			 <value>com.apgsga.vk.preisermittlung.db.ContextLoadingDao</value>
		</property>
		<property name="target">
			<ref local="rabattDao"/>
		</property>
		<property name="interceptorNames">
			<list>
				<value>performanceMontitor</value>
			</list>
		</property>
	</bean>

and the performance monitor:

	<bean id="performanceMontitor" 
		class="org.springframework.aop.interceptor.PerformanceMonitorInterceptor">
	</bean>

I have different Dao's like the one above (rabattDao) all implementing the same Interface.
My problem is that the name, which is logged is for all the same: the interface they implement.
I would actually like to see the class name of the target.

Christoph

[robh]

Christoph,

Try setting the 'proxyTargetClass' property of ProxyFactoryBean to true.

Rob

[chenrici]

Hi Rob,

somehow the bean's don't load after setting the proxyTargetClass in the ProxyFactoryBean to true.

I get the following exception stack:

 [junit] 1) testService(com.apgsga.vk.preisermittlung.service.BatchServiceInterfaceImplTests)org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'monitoredrabattDao' defined in class path resource [batchtestbeans.xml]: Initialization of bean failed; nested exception is org.aopalliance.aop.AspectException: null
    [junit] java.lang.IllegalStateException: Callback Lnet/sf/cglib/proxy/MethodInterceptor; is not assignable to Lnet/sf/cglib/proxy/MethodInterceptor;
    [junit] at net.sf.cglib.proxy.Enhancer.validate(Enhancer.java:374)
    [junit] at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:399)
    [junit] at net.sf.cglib.proxy.Enhancer.create(Enhancer.java:318)
    [junit] at org.springframework.aop.framework.Cglib2AopProxy.getProxy(Cglib2AopProxy.java:194)
    [junit] at org.springframework.aop.framework.Cglib2AopProxy.getProxy(Cglib2AopProxy.java:150)
    [junit] at org.springframework.aop.framework.ProxyFactoryBean.getSingletonInstance(ProxyFactoryBean.java:256)
    [junit] at org.springframework.aop.framework.ProxyFactoryBean.setBeanFactory(ProxyFactoryBean.java:220)
    [junit] at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:349)
    [junit] at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:223)
    [junit] at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
    [junit] at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:271)
    [junit] at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:312)
    &#91;junit&#93; at org.springframework.context.support.ClassPathXmlApplicationContext.<init>&#40;ClassPathXmlApplicationContext.java&#58;80&#41;
    &#91;junit&#93; at org.springframework.context.support.ClassPathXmlApplicationContext.<init>&#40;ClassPathXmlApplicationContext.java&#58;65&#41;
    &#91;junit&#93; at org.springframework.test.AbstractSpringContextTests.loadContextLocations&#40;AbstractSpringContextTests.java&#58;113&#41;
    &#91;junit&#93; at org.springframework.test.AbstractDependencyInjectionSpringContextTests.loadContextLocations&#40;AbstractDependencyInjectionSpringContextTests.java&#58;147&#41;
    &#91;junit&#93; at org.springframework.test.AbstractSpringContextTests.getContext&#40;AbstractSpringContextTests.java&#58;95&#41;
    &#91;junit&#93; at org.springframework.test.AbstractDependencyInjectionSpringContextTests.setUp&#40;AbstractDependencyInjectionSpringContextTests.java&#58;114&#41;

Probably did something wrong?

	<bean id="monitoredlokalDispoPositionenDao" 
		class="org.springframework.aop.framework.ProxyFactoryBean">
		<property name="proxyInterfaces">
			<value>com.apgsga.vk.preisermittlung.db.LokalDispoDao</value>
		</property>
		<property name="target">
			<ref local="lokalDispoPositionenDao"/>
		</property>
		<property name="proxyTargetClass">
			<value>true</value>
		</property>
		<property name="interceptorNames">
			<list>
				<value>performanceMontitor</value>
			</list>
		</property>
	</bean>

[robh]

Ah, you need to upgrade the version of CGLIB you are using. I've seen that particular error in an older version of CGLIB (can't remember which one exactly). Try using the CGLIB jar pacakged with the latest Spring release.

Rob

[chenrici]

I updated the cglib to the newest version. That got me further.
But now i get a null pointer exception on the jdbcTemplate for the second invocation of a dao:

    [junit] .com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtSelektionDaoImpl.load : 0:00:09.994
    [junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtSelektionDaoImpl.load : 0:00:09.994
    [junit] jdbcTemplate: null
    [junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoImpl.createQuery : 0:00:00.000
    [junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoImpl.createQuery : 0:00:00.000
    [junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.AbstractContextCreatingQueryDaoImpl.getParameterValueMap : 0:00:00.000
    [junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.AbstractContextCreatingQueryDaoImpl.getParameterValueMap : 0:00:00.000
    [junit] com.apgsga.vk.preisermittlung.service.BatchingServiceInterfaceImpl - Severe Error: java.lang.NullPointerException
    [junit] com.apgsga.vk.preisermittlung.service.BatchingServiceInterfaceImpl - Stacktrace:

I have tried different DataSource implementations:

	<bean id="dataSource" 
		class="org.apache.commons.dbcp.BasicDataSource">
		<property name="driverClassName">
			<value>oracle.jdbc.OracleDriver</value>
		</property>
		<property name="url">
			<value>jdbc&#58;oracle&#58;thin&#58;@testserver&#58;1521&#58;test1</value>
		</property>
		<property name="password">
			<value>xxxxx</value>
		</property>
		<property name="username">
			<value>vk</value>
		</property>
	</bean>

All fail. I am not sure, if the problem is restricted to the JdbcTemplate.
I am still debugging, but maybe you saw already something similiar?

[chenrici]

Additional information to above:
I construct the JdbcTemplate with the datasource property the afterPropertiesSet Method of a Dao Bean and store it locally.
When i retrieve the JdbcTemplate in the proxied Dao via getter Method it is null. Without the proxy it works fine?

[robh]

Can you show the full stack trace and the test code?

Rob

[chenrici]

Great thanx Rob for your help.
The log4j console output of the junit run, with debug enabled is quite extensive (1386).
Shall i post it?

Christoph