Bug in ActionStateAction

[cmrudd]

Not sure if this where bugs are to be reported for WebFlows, but...

In ActionStateAction, when using the constructor signature ActionStateAction( Action, Properties) or ActionStateAction( ActionState, Action, Properties ), the passed properties are set into the properties member via :

this.properties = new Properties( passedProperties );

That is fine, except that you must use Properties.getProperty method (and not the Properties.get method) for the Properties object to cascade into its wrapped Properties object.

So the method ActionStateAction.getProperty needs to be changed from this :

return (String)getProperties().get( propertyName );

to

return getProperties().getProperty( propertyName );

this will ensure that the properties are propertly retrieved.

Another thing to note is that the ActionStateAction.containsProperty has a similar issue as the Properties.containsKey method does not cascade the cehck to its wrapped Properties instance, so calling it when you you have used one of the constructors mentioned above will always return false for any properties located in the Properties object passed in.

Example :

Proprties props = new Properties();
props.setProperty( ActionStateAction.METHOD_PROPERTY, "cancelAction" );

Action action = new SomeActionClass();

ActionStateAction asa  = new ActionStateAction( action, properties );

asa.setProperty( "MODE", "A" );

assert( "A".equals( asa.getProperty("MODE") ) ); // Assert passes
assert( asa.containsKey( "MODE" ) ); // Assert passes

assert( "cancelAction".equals( asa.getProperty("MODE") ) ); // Assert fails
assert( asa.containsKey( "MODE" ) ); // Assert fails

[Keith Donald]

Please upgrade to PR3. that class is now obsolete.

[cmrudd]

Thx. The response does beg the question...

How stable is api? And when is the eta of it to be stable?

[klr8]

Check http://forum.springframework.org/showthread.php?t=15228

Erwin

[cmrudd]

Thx for the timely reponses )