Proxy DataSource

[tripperm]

From some other posts on this forum it appears that it should be possible to proxy a DataSource. I have attempted to do this but get a strange error from Spring. Here is my setup:

    <bean id="account" class="com.pdsisoft.AccountImpl">
        <property name="dataSource">
            <ref local="dataProxy"/>
        </property>
    </bean>

    <bean id="dataProxy" class="org.springframework.aop.framework.ProxyFactoryBean">
        <property name="target">
            <ref local="myDataSource"/>
        </property>
        <property name="interceptorNames">
            <list>
                <value>advisor</value>
            </list>
        </property>
    </bean>

    <bean id="advice" class="com.pdsisoft.core.spring.DataSourceInterceptor"/>
    <bean id="advisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
        <property name="advice">
            <ref local="advice"/>
        </property>
        <property name="pointcut">
            <bean class="org.springframework.aop.support.JdkRegexpMethodPointcut">
                <property name="pattern">
                    <value>.*getConnection.*</value>
                </property>
            </bean>
        </property>
    </bean>
    
    <bean id="myDataSource" class="org.apache.commons.dbcp.BasicDataSource" destroy-method="close">
        <property name="driverClassName">
            <value>com.informix.jdbc.IfxDriver</value>
	</property>
	<property name="url">
            <value>&#91;ommitted&#93;</value>
	</property>
	<property name="username">
            <value>&#91;ommitted&#93;</value>
	</property>
	<property name="password">
            <value>&#91;ommitted&#93;</value>
	</property>
    </bean>

When Spring starts up it immediately throws the following exception:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name '/getAccounts' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Can't resolve reference to bean 'account' while setting property 'account'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'account' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Can't resolve reference to bean 'dataSourceProxy' while setting property 'dataSource'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSourceProxy' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Initialization of bean failed; nested exception is org.aopalliance.aop.AspectException: null
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'account' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Can't resolve reference to bean 'dataSourceProxy' while setting property 'dataSource'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSourceProxy' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Initialization of bean failed; nested exception is org.aopalliance.aop.AspectException: null
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSourceProxy' defined in ServletContext resource [/WEB-INF/applicationContext.xml]: Initialization of bean failed; nested exception is org.aopalliance.aop.AspectException: null
net.sf.cglib.core.CodeGenerationException: java.lang.reflect.InvocationTargetException-->null
	at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:236)
	at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:368)
	at net.sf.cglib.proxy.Enhancer.create(Enhancer.java:280)
	at org.springframework.aop.framework.Cglib2AopProxy.getProxy(Cglib2AopProxy.java:194)
	at org.springframework.aop.framework.Cglib2AopProxy.getProxy(Cglib2AopProxy.java:150)
	at org.springframework.aop.framework.ProxyFactoryBean.getSingletonInstance(ProxyFactoryBean.java:256)
	at org.springframework.aop.framework.ProxyFactoryBean.setBeanFactory(ProxyFactoryBean.java:220)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:344)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:257)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:223)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.resolveReference(AbstractAutowireCapableBeanFactory.java:1021)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.resolveValueIfNecessary(AbstractAutowireCapableBeanFactory.java:944)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:885)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:714)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:331)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:257)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:223)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.resolveReference(AbstractAutowireCapableBeanFactory.java:1021)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.resolveValueIfNecessary(AbstractAutowireCapableBeanFactory.java:944)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:885)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:714)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:331)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:257)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:223)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:277)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:319)
	at org.springframework.web.context.support.AbstractRefreshableWebApplicationContext.refresh(AbstractRefreshableWebApplicationContext.java:131)
	at org.springframework.web.context.ContextLoader.createWebApplicationContext(ContextLoader.java:230)
	at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:156)
	at org.springframework.web.context.ContextLoaderServlet.init(ContextLoaderServlet.java:81)
	at javax.servlet.GenericServlet.init(GenericServlet.java:256)
	at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1044)
	at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:887)
	at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:3959)
	at org.apache.catalina.core.StandardContext.start(StandardContext.java:4284)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:866)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:850)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:638)
	at org.apache.catalina.core.StandardHostDeployer.addChild(StandardHostDeployer.java:839)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.apache.commons.beanutils.MethodUtils.invokeMethod(MethodUtils.java:252)
	at org.apache.commons.digester.SetNextRule.end(SetNextRule.java:256)
	at org.apache.commons.digester.Rule.end(Rule.java:276)
	at org.apache.commons.digester.Digester.endElement(Digester.java:1058)
	at org.apache.catalina.util.CatalinaDigester.endElement(CatalinaDigester.java:123)
	at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
	at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
	at org.apache.commons.digester.Digester.parse(Digester.java:1567)
	at org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:519)
	at org.apache.catalina.core.StandardHost.install(StandardHost.java:906)
	at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:527)
	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:472)
	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1008)
	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:394)
	at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166)
	at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1134)
	at org.apache.catalina.core.StandardHost.start(StandardHost.java:832)
	at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1126)
	at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:521)
	at org.apache.catalina.core.StandardService.start(StandardService.java:519)
	at org.apache.catalina.core.StandardServer.start(StandardServer.java:2345)
	at org.apache.catalina.startup.Catalina.start(Catalina.java:594)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:297)
	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:398)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at net.sf.cglib.core.ReflectUtils.defineClass(ReflectUtils.java:373)
	at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:218)
	... 79 more
Caused by: java.lang.NoClassDefFoundError: org/springframework/aop/framework/Advised
	at java.lang.ClassLoader.defineClass0(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:537)
	... 85 more

What is really strange is that if I change the target for the ProxyFactoryBean to be any other bean except my datasource, Spring starts up without any problem.

Any ideas on what is going on?

Thanks

[Costin Leau]

Caused by: java.lang.NoClassDefFoundError: org/springframework/aop/framework/Advised
at java.lang.ClassLoader.defineClass0(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java :537)
... 85 more

It looks like you are missing the Advised interface. Do you have the whole spring.jar or spring-aop.jar inside your classpath? Make sure there are no conflicts with previous spring versions (i.e. you have only one version of spring inside the classpath).

[tripperm]

The springg.jar file is bundeled in my war application. I noticed the calss not found exception too. But what is strange is that when I proxy another object using the ProxyFactory I have defined, spring loads up, the application runs, and the proxy works correctly. So if it was a missing classpath reference, this would blow up too.

What I am wondering is if spring is trying to proxy the datasource once it is created and not all of springs classes have been loaded. I'm thinking of moving the spring.jar file into the server/lib folder to see if it makes any difference.

[tripperm]

I put the spring.jar file into my tomcat server/lib folder and it made no difference. I also verified that the missing class is indeed in the jar file. There are no other references to any other apring classes anywhere in my classpath.

And as I said in my original post, making the proxied class any other class except my datasource works. For example, this configuration runs wiht no errors at all:

    <bean name="/userRegistration" class="com.pdsisoft.UserRegistrationAction" singleton="false">
        <property name="registration">
            <ref bean="dataProxy"/>
        </property>
    </bean>

    <bean id="registerTrue" class="com.pdsisoft.RegistrationImplAlwaysTrue" singleton="false"/>

    <bean id="dataProxy" class="org.springframework.aop.framework.ProxyFactoryBean">
        <property name="target">
            <ref local="registerTrue"/>
        </property>
        <property name="interceptorNames">
            <list>
                <value>advisor</value>
            </list>
        </property>
    </bean>

    <bean id="advice" class="com.pdsisoft.core.spring.DataSourceInterceptor"/>
    <bean id="advisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
        <property name="advice">
            <ref local="advice"/>
        </property>
        <property name="pointcut">
            <bean class="org.springframework.aop.support.JdkRegexpMethodPointcut">
                <property name="pattern">
                    <value>.*doRegistration.*</value>
                </property>
            </bean>
        </property>
    </bean>

No classpath exceptions are thrown, and the proxy works ( I have a println statement in it to let me know it was fired, and it does go off ).

So how can proxying a datasource cause a problem, but proxying another class, with the same ProxyFactoryBean setup not work?

I'm stumped.

[Costin Leau]

If you are using JBoss then most probably you have some jars (like the datasource library) placed inside server/lib and spring inside the war which does lead to CNF due to the way JBoss classloader works. There are some flags which you can set but they are not very well documented and might lead to conflicts afterwards so it's better to place all your libraries inside the same dir (i.e. server/lib).

[Costin Leau]

We wrote the posts at the same time - talking about concurrency .
Take a look at the DBCP datasource class - maybe it's final, abstract or just an interface and try using a different datasource like c3p0.

[tripperm]

Costin,

Your first post was dead on the money!

I am using Tomcat 5 and I had suspected earlier that it had to do something with the order classes were being loaded in Tomcat. So I moved the spring jar files into the common\lib folder (the Tomcat docs say that what is in there will be loaded before any other application specific code). This ensured that Spring would be loaded first before my datasource which was proxied. Once I did this everything worked fine. I can now successfully proxy my data source.

Thanks for the help.

[Costin Leau]

Allright! Anyways make sure you have a clean classpath - it will save you some trouble in the long term.