test failures when building latest version from github

[cailie]

Hi there,

I've just cloned the spring-security-saml github repository at https://github.com/SpringSource/spring-security-saml.

Building with `mvn package` produces test failures and errors, pasted below. Does anyone else get these?

Thanks,
-C

-----
Results :

Failed tests: testMissingResponse(org.springframework.security.s aml.websso.WebSSOProfileConsumerImplTest):
testInvalidResponseObject(org.springframework.secu rity.saml.websso.WebSSOProfileConsumerImplTest):
testDefaultAuthNStatementPasses(org.springframewor k.security.saml.websso.WebSSOProfileConsumerImplTe st):
testAuthNStatementWithExpiredSessionTime(org.sprin gframework.security.saml.websso.WebSSOProfileConsu merImplTest):
testAuthnExactComparison(org.springframework.secur ity.saml.websso.WebSSOProfileConsumerImplTest):
testAuthnExactComparison_none(org.springframework. security.saml.websso.WebSSOProfileConsumerImplTest ):
testCondition_empty(org.springframework.security.s aml.websso.WebSSOProfileConsumerImplTest):
testCondition_empty_audienceRequired(org.springfra mework.security.saml.websso.WebSSOProfileConsumerI mplTest):
testCondition_Audience_pass(org.springframework.se curity.saml.websso.WebSSOProfileConsumerImplTest):
testCondition_Audience_fail(org.springframework.se curity.saml.websso.WebSSOProfileConsumerImplTest):
testCondition_OneTimeUse(org.springframework.secur ity.saml.websso.WebSSOProfileConsumerImplTest):
verifySubject(org.springframework.security.saml.we bsso.WebSSOProfileConsumerImplTest):
verifySubjectNotOnOrAfterExceeded(org.springframew ork.security.saml.websso.WebSSOProfileConsumerImpl Test):
verifySubjectMissingNotOnOrAfter(org.springframewo rk.security.saml.websso.WebSSOProfileConsumerImplT est):
testIDPSelection_defaultURL(org.springframework.se curity.saml.SAMLEntryPointTest):
testCorrectIDP(org.springframework.security.saml.S AMLEntryPointTest):
testPopulateLocalEntityNullPath(org.springframewor k.security.saml.context.SAMLContextProviderImplTes t):
testPopulateLocalEntityNoAlias(org.springframework .security.saml.context.SAMLContextProviderImplTest ):
testPopulateLocalEntityAliasNoRole(org.springframe work.security.saml.context.SAMLContextProviderImpl Test):
testPopulateLocalEntityAliasSPRole(org.springframe work.security.saml.context.SAMLContextProviderImpl Test):
testPopulateLocalEntityAliasDefaultRole(org.spring framework.security.saml.context.SAMLContextProvide rImplTest):
testPopulateLocalEntityAliasIDPRole(org.springfram ework.security.saml.context.SAMLContextProviderImp lTest):
testPopulateCredentialLocalEntity(org.springframew ork.security.saml.context.SAMLContextProviderImplT est):
testPOSTResponseParsing(org.springframework.securi ty.saml.processor.SAMLProcessorImplTest):
testMessageRecipientInvalid(org.springframework.se curity.saml.processor.SAMLProcessorImplTest):
testGETDecoder(org.springframework.security.saml.p rocessor.SAMLProcessorImplTest):
testUnknownDecoder(org.springframework.security.sa ml.processor.SAMLProcessorImplTest):
testMessageInvalidSignature(org.springframework.se curity.saml.processor.SAMLProcessorImplTest):
testCorrectPass(org.springframework.security.saml. SAMLProcessingFilterTest):

Tests in error:
testInvalidIDP(org.springframework.security.saml.S AMLEntryPointTest): Unexpected exception, expected<javax.servlet.ServletException> but was<java.lang.AssertionError>
testPopulateLocalEntityAliasInvalidRole(org.spring framework.security.saml.context.SAMLContextProvide rImplTest): Unexpected exception, expected<org.opensaml.saml2.metadata.provider.Meta dataProviderException> but was<java.lang.AssertionError>
testPopulateLocalEntityComplexAliasIDPRole_missing Role_SP(org.springframework.security.saml.context. SAMLContextProviderImplTest): Unexpected exception, expected<org.opensaml.saml2.metadata.provider.Meta dataProviderException> but was<java.lang.AssertionError>
testPopulateCredentialLocalEntity_invalidName(org. springframework.security.saml.context.SAMLContextP roviderImplTest): Unexpected exception, expected<org.opensaml.saml2.metadata.provider.Meta dataProviderException> but was<java.lang.AssertionError>
testInvalidBinding(org.springframework.security.sa ml.SAMLProcessingFilterTest): Unexpected exception, expected<org.opensaml.common.SAMLRuntimeException> but was<java.lang.AssertionError>
testErrorDuringProcessing(org.springframework.secu rity.saml.SAMLProcessingFilterTest): Unexpected exception, expected<org.opensaml.common.SAMLRuntimeException> but was<java.lang.AssertionError>

Tests run: 144, Failures: 29, Errors: 6, Skipped: 0

[vsch]

Hi,

There were some uncommitted leftovers from previous changes, just rebase and the tests should pass ok. Sorry for inconvenience.

Vladimír Schäfer

[cailie]

Vladimír,

I rebased and all the tests pass now. Thank you for your help and very quick reply!

Cheers,
-C

Hi,

There were some uncommitted leftovers from previous changes, just rebase and the tests should pass ok. Sorry for inconvenience.

Vladimír Schäfer