How should I process Exception in DAO?

[liren]

Hi friends:

I want to know how to process Exception in DAO layer. For example.there are two method to do this:
one method:

public class PersonDAOImpl implements PersonDAO{ 
    
       public void updatePerson(Person p){ 
             ........................................... 
             try{ 
                       session.update(p); 
                       tx.commit(); 
                  }catch(HibernateException ex){ 
                          tx.rollback(); 
                          ex.printStackTrace(); 
                    }finally{ 
                            session.close(); 
                      } 
                  ....................................

Two method:

public void updatePerson(Person p){ 
             ........................................... 
             try{ 
                       session.update(p); 
                       tx.commit(); 
                  }catch(HibernateException ex){ 
                         throw new MyException("HibernateEx"); 
                    }

If I use the second, I can catch the "MyException" in Servlet and sendRedirect to the specific error page.But I can't process it finally for example rollback transaction or close session.
If I use the first one,I can't catch the Exception in Servlet ,So I can't send redirect to the specific error page.
Which is better ? Shoud I process exception in DAO Layer or web layer? Thks!
[/code]

[katentim]

Why not let Spring manage your Hibernate session and transaction - see samples.

If you need a completly separate page to display the error, try using an exception resolver (also in samples):

<bean id="exceptionResolver" class="org.springframework.web.servlet.handler.SimpleMappingExceptionResolver">
   <property name="exceptionMappings">
      <props>
         <prop key="org.springframework.dao.DataAccessException">dataAccessFailure</prop>
         <prop key="org.yourcompany.DatabaseErrorException ">dataAccessFailure</prop>
      </props>
   </property>
</bean>

dataAccessFailure.class=org.springframework.web.servlet.view.JstlView
dataAccessFailure.url=/WEB-INF/jsp/dataAccessFailure.jsp

[liren]

Thks for your reply.
Because I throws DataAccessException in all DAO class method. So I couldn't catch specific exception in my Servlet and proccess them in different way. DataAccessException is a RuntimeException,so I could't catch it in Servlet. How to send Redirect to different error page according different condition?

[creatxr]

Thks for your reply.
Because I throws DataAccessException in all DAO class method. So I couldn't catch specific exception in my Servlet and proccess them in different way. DataAccessException is a RuntimeException,so I could't catch it in Servlet. How to send Redirect to different error page according different condition?

you can use org.springframework.orm.hibernate.SessionFactoryUt il

to convert to DataAccessException

[Rod Johnson]

Why not catch the DataAccessException subclasses you can recover or retry in the DAO layer? Or business layer? DataAccessException provides an informative hierarchy to facilitate this.

[liren]

Why not catch the DataAccessException subclasses you can recover or retry in the DAO layer? Or business layer? DataAccessException provides an informative hierarchy to facilitate this.

Now,I write a class that extends DataAccessException. For example:

 public class MyDataAccessException extends DataAccessException{
 ................................. 
  }
 public class YourDataAccessException extends DataAccessException{
 ................................. 
  }

In servlet , I can do it in this way:

 public class myServlet extends HttpServlet{
  public void doPost(.......................)....{
        try{
                mydao.getList();
            }catch(MyDataAccessException myex){
                   //do something
            }catch(YourDataAccessException yourex){
                   //do something
            }

Or in this way:

public void doPost(.......................)....{
        try{
                mydao.getList();
            }catch(Exception  myex){
              if(myex instanceof MyDataAccessException){
                   //do something
                }
            }catch(YourDataAccessException yourex){
               if(yourex instanceof YourDataAccessException){
                   //do something
                }
            }

That what you mean? It is right method to do this? I mean that I could catch DataAccessException thought it is runtimeException?

[irbouho]

Among DataAccessException subclasses are DataIntegrityViolationException, CannotAcquireLockException, CannotSerializeTransactionException, TypeMismatchDataAccessException... I think all classes/exception in org.springframework.dao package.
Basically, you can either catch one of those exceptions, or, as you did in your code, create your own application exception if no equivalent exception is provided by Spring.
HTH