Spring DAO + Hibernate; Am I doing this right?

[gdboling]

I have just started adding Spring's DAO support into my JSF+Hibernate application. Since I am really new to all this DAO stuff I'd like to post my code and get feedback on what I have done right and/or what I should do differently. I will not be including my hibernate mapping files as they work fine and this is more about implementing Spring's DAO. Thanks for any tips/advice you can give me.

The following code is all for my User class and getting a user via a username and password for logging in.

applicationContext.xml

<beans>
    <bean id="dataSource" class="org.springframework.jndi.JndiObjectFactoryBean">
        <property name="jndiName">
            <value>java&#58;comp/env/jdbc/anykey</value>
        </property>
    </bean>
 
    <bean id="sessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
        <property name="dataSource">
            <ref bean="dataSource"/>
        </property>
        <property name="hibernateProperties">
            <props>
                <prop key="hibernate.dialect">org.hibernate.dialect.MySQLInnoDBDialect</prop>
            </props>
        </property>
        <property name="mappingDirectoryLocations">
            <list>
                <value>classpath&#58;/com/intrust/anykey/database/hibernate/mappings</value>
            </list>
        </property>
    </bean>
    
    <bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">
        <property name="sessionFactory">
            <ref bean="sessionFactory"/>
        </property>
    </bean>
 
    <bean id="hibernateTemplate" class="org.springframework.orm.hibernate3.HibernateTemplate">
        <property name="sessionFactory">
            <ref bean="sessionFactory"/>
        </property>
    </bean>
    
    <bean id="userDao" class="com.intrust.anykey.database.dao.hibernate.UserDaoHib">
        <property name="hibernateTemplate">
            <ref bean="hibernateTemplate"/>
        </property>
    </bean>        
 
    <bean id="userServiceTarget" class="com.intrust.anykey.database.dao.services.UserServiceImpl">
        <property name="userDao">
            <ref bean="userDao"/>
        </property>
    </bean>
 
    <bean id="userService" class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
        <property name="transactionManager">
            <ref bean="transactionManager"/>
        </property>
        <property name="target">
            <ref bean="userServiceTarget"/>
        </property>
        <property name="transactionAttributes">
            <props>
                <prop key="getUser">PROPAGATION_REQUIRED</prop>
            </props>
        </property>
    </bean>
</beans>

UserService

public interface UserService {
    public void setUserDao(UserDAO userDao);
    public User getUser(String username, String password);
}

UserServiceImpl

public class UserServiceImpl implements UserService {
    
    private UserDAO userDao;
 
    public void setUserDao(UserDAO userDAO){
        this.userDao = userDAO;
    }
    
    public User getUser(String username, String password) {
        return userDao.load(username, password);
    }
}

UserDAO

public interface UserDAO {
	public User load(String username, String password);
}

UserDaoHib

public class UserDaoHib implements UserDAO {
 
    private HibernateTemplate hibernateTemplate;
 
    public void setHibernateTemplate(HibernateTemplate template){
        this.hibernateTemplate = template;
    }
 
    public User load(String username, String password) {
        String passHash = MD5.getHash(password);
        final Map map = new HashMap();
            map.put("username", username);
            map.put("password", passHash);
 

       return (User)hibernateTemplate.execute(new HibernateCallback() {
            public Object doInHibernate(Session session) throws HibernateException{
                return session.createCriteria(User.class).add(Restrictions.allEq(map)).uniqueResult();
            }
        });
}

User Login Snippet

ApplicationContext context = WebApplicationContextUtils.getWebApplicationContext(getContext());            
UserService userDAO = (UserService)context.getBean("userService");
User user = userDAO.getUser(username, password);

[irbouho]

As far as I can see, the config / code look OK. I have however some questions / remarks:
- You seem to be using Spring support Hibernate3 from JIRA, Juergen will be comiting some code to sandbox soon.
- There should be HibernateDaoSupport class that ease the creation of Dao Classes
- getUser should be marked PROPAGATION_REQUIRED,readOnly I think.
HTH

[gdboling]

As far as I can see, the config / code look OK. I have however some questions / remarks:
- You seem to be using Spring support Hibernate3 from JIRA, Juergen will be comiting some code to sandbox soon.
- There should be HibernateDaoSupport class that ease the creation of Dao Classes
- getUser should be marked PROPAGATION_REQUIRED,readOnly I think.
HTH

I actually started using the HibernateDaoSupport. It's kind of a catch 22 on some things though. I really like using the Criteria and Expression API rather than writing a bunch of HQL. It would seem that without using the Callback to get access to the actual Hibernate Session, using those API's is impossible. And thanks for the info on the getUser method.

An add-on question. Right now I am adding a new service declaration

<bean id="userService" class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
        <property name="transactionManager">
            <ref bean="transactionManager"/>
        </property>
        .............................

for each service class I have. Is there a way to define 1 service bean and just add targets to keep the applicationContext more concise?

[irbouho]

You can use a template with some inner beans as follows:

  <!-- transactional service template -->
  <bean id="txProxyTemplate"
     class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean"
     abstract="true"
     lazy-init="true">
    <property name="transactionManager">
      <ref bean="transactionManager"/>
    </property>
    <property name="transactionAttributes">
      <props>
        <prop key="get*">PROPAGATION_REQUIRED,readOnly</prop>
        <prop key="set*">PROPAGATION_REQUIRED</prop>
        <prop key="save*">PROPAGATION_REQUIRED</prop>
        <prop key="delete*">PROPAGATION_REQUIRED</prop>
      </props>
    </property>
  </bean>

  <bean id="userManager" parent="txProxyTemplate">
    <property name="proxyInterfaces">
      <value>org.taha.service.UserManager</value>
    </property>
    <property name="target">
      <bean class="org.taha.service.UserManagerImpl">
        <property name="userDAO">
          <ref bean="userDAO"/>
        </property>
      </bean>
    </property>
  </bean>

HTH