[neo4j] Validation

[loki2302]

Need some help making bean validation work with SDN:

@NodeEntity 
public class Dummy {
	@GraphId 
	Long id;
	
	@Indexed 
	@NotNull 
	String x; // want this to never be null
	
	public Dummy() {}
	public Dummy(String x) {
		this.x = x;
	}
}

public interface DummyRepository extends GraphRepository<Dummy> {}

@ContextConfiguration(locations = "classpath:/context.xml")
@RunWith(SpringJUnit4ClassRunner.class)
public class DummyTest {	
	@Autowired private DummyRepository dummyRepository;
	@Autowired private Neo4jTemplate neo4jTemplate; 
	
	@Before public void dropDb() {
		Neo4jHelper.cleanDb(neo4jTemplate);
	}
	
	@Test(expected = ValidationException.class) 
	public void testNullX() {
		Dummy dummy = new Dummy(null);
		dummyRepository.save(dummy);
	}
}

context.xml is:

    <context:spring-configured/>
    <context:annotation-config/>
    
    <bean id="validator" class="org.hibernate.validator.HibernateValidator"/>	
    <neo4j:config storeDirectory="target/neo4j-db"/>
    <neo4j:repositories base-package="com.XXXXXXXXXX.repositories" />
        
    <tx:annotation-driven mode="proxy" />

I have hibernate-validator 4.2.0 dependency in my pom.xml. The test fails since there's no ValidationException. Anything I'm missing?

[MichaelHunger]

I just tried it and it works, are you sure you use the correct @javax.validation.constraints.NotNull annotation? There are soo many around?

[loki2302]

are you sure

Well, now that you ask, I'm not :-)

I have this dependency:

		<dependency>
			<groupId>javax.validation</groupId>
			<artifactId>validation-api</artifactId>
			<version>1.0.0.GA</version>
		</dependency>

I've also tried using @NotEmpty and @NotBlank annotations from hibernate-validator package - still no success, it just doesn't throw. Anything else you think I should check?

[MichaelHunger]

Could you try to reproduce the test that is contained in SDN ?

Thanks

Michael

[loki2302]

Downloaded recent commit from github:

Results :

Failed tests:
  injectionForCodeConfiguredExistingGraphDatabaseService(org.springframework.data.neo4j.config.DataGraphNamespaceHandlerTest)
  injectionForExistingGraphDatabaseService(org.springframework.data.neo4j.config.DataGraphNamespaceHandlerTest)
  injectionForConversionService(org.springframework.data.neo4j.config.DataGraphNamespaceHandlerTest)
  injectionForJustStoreDir(org.springframework.data.neo4j.config.DataGraphNamespaceHandlerTest)

Tests run: 256, Failures: 4, Errors: 0, Skipped: 4

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Spring Data Neo4j Parent .......................... SUCCESS [0.461s]
[INFO] Spring Data Neo4j ................................. FAILURE [1:09.906s]
[INFO] Spring Data Neo4J Aspects ......................... SKIPPED
[INFO] Spring Data Neo4j REST Wrapper .................... SKIPPED
[INFO] Spring Data Neo4J Cross-Store Handling ............ SKIPPED
[INFO] Spring Data Neo4j Distribution .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:10.892s
[INFO] Finished at: Tue Apr 24 13:39:09 MSD 2012
[INFO] Final Memory: 33M/327M
[INFO] ------------------------------------------------------------------------

[loki2302]

Fixed my code by replacing:

<bean id="validator" class="org.hibernate.validator.HibernateValidator"/>

with:

<bean id="validator" class="org.springframework.validation.beanvalidation.LocalValidatorFactoryBean"/>

[MichaelHunger]

Thanks for pointing it out, that's the way the SDN tests are set up too, I added it to the docs.

Cheers

Michael