Wiring Problems in Spring Integration

[annuk]

Hi,

While using SI for software development i came across a problem.

In my case, Spring Integration does not work properly if i use Setter Injection

When i use @Autowired for wiring my beans, it works fine. But when i set the property using Setter Injection.
It is acting wierd.

Instead of my message going to the next channel i.e set, it goes to the Property bean.

Say my configuration is:

<bean id="messageElementRefBean"
      class="org.springbyexample.springindepth.bean.Message">
    <property name="message" ref="springMessage"/></property>
</bean>

In this case it will print the springMessageBean object.

And if i use @Autowired.The program works properly.

What am i doing wrong?

Regards,
Annuk

[annuk]

Hi,
has any one faced the above issue.

Regards,
Annuk

[Gary Russell]

I didn't see your original message for some reason.

I don't understand what you are saying; especially the bit about a message "going" to a property bean. And, what is "it" when you say "...it will print"?

You need to provide more context - what you are trying to do, code, config etc.

[annuk]

Hi Gary,

Thanks for your reply.
I am just trying to create a simple spring integration project.

It works fine only when i use @Autowired to wire the beans.

Say my config is:

<bean id="smsAdapter.htm"  name="/smsAdapter.htm"  class="org.springframework.integration.http.inbound.HttpRequestHandlingMessagingGateway">
  <constructor-arg value="true" />
  <property name="requestChannel" ref="smsChannel" />
  <property name="replyChannel" ref="gatewayChannel" />
  <property name="supportedMethodNames" >
    <list>
      <value>GET</value>
    </list>
  </property>
</bean>

<int:transformer id="smsSyncMasters" input-channel="smsChannel"
		output-channel="gatewayChannel" ref="messageReceiver"  >
</int:transformer>

<bean id="messageReceiver" class="com.test.messaging.MessageReceiver" />

<bean id="messageService" class="com.test.messaging.MessageService" />

My message Receiver class is as follows:

public class MessageReceiver
{

       @Autowired
        private ImessageService messageService;

	public Message<String> recieveRequest(Message<Map<String,List<String>>> smsData)
	{
		System.out.println("Request Received::"+smsData.getPayload());
		
		Map<String,List<String>> dataString = smsData.getPayload();
		
		List<String> lists =  dataString.get("content");
		
		System.out.println("Content list "+lists);
		
		String data = messageService.get(lists.get(0));
		
		System.out.println("Data is "+data);
		return MessageBuilder.withPayload(data).build();
		
	}
}

If i Autowire my messageService property, i get a response back.
But if i use a setter injection instead of Autowire, i dont get any response from the messaging gateway.

EG:

public class MessageReceiver
{

        private ImessageService messageService;

        public void setMessageService(imessageService args)
        {
          this.messageService = args;
        }

     public imessageService getMessageService()
        {
         return  this.messageService;
        }
	public Message<String> recieveRequest(Message<Map<String,List<String>>> smsData)
	{
		System.out.println("Request Received::"+smsData.getPayload());
		
		Map<String,List<String>> dataString = smsData.getPayload();
		
		List<String> lists =  dataString.get("content");
		
		System.out.println("Content list "+lists);
		
		String data = messageService.get(lists.get(0));
		
		System.out.println("Data is "+data);
		return MessageBuilder.withPayload(data).build();
		
	}
}


change in configuration

<bean id="messageReceiver" class="com.test.messaging.MessageReceiver" >
<property name="messageService" ref="messageService"/>
</bean>

Setter injection gives me no output whereas Autowire works properly.
Hope you understood the problem.

Regards,
Annuk

[Gary Russell]

That doesn't make any sense; I suggest you run with DEBUG logging; you should be able to see what's going on.

By the way, you really don't need to expose the messaging system to your service; it can look like this...

public class MessageReceiver
{

       @Autowired
        private ImessageService messageService;

	public String recieveRequest(Map<String,List<String>> smsData)
	{
		System.out.println("Request Received::"+smsData);
		
		List<String> lists =  smsData.get("content");
		
		System.out.println("Content list "+lists);
		
		String data = messageService.get(lists.get(0));
		
		System.out.println("Data is "+data);
		return data;
		
	}
}

It shouldn't make any difference to your problem, but I hope you can see that it removes all deps on S.I. and you have a more easily testable unit.

You could go a step further and use a SpEL expression to eliminate your MessageReceiver altogether and invoke your message service directly...

<int:transformer id="smsSyncMasters" input-channel="smsChannel"
		output-channel="gatewayChannel" expression="@messageService.get('payload['content'].get(0))"  >
</int:transformer>

[Amol Nayak]

But if i use a setter injection instead of Autowire, i dont get any response from the messaging gateway.

Do you see a NullPointerException on the server side?

<bean id="messageReceiver" class="com.test.messaging.MessageReceiver" />

<bean id="messageService" class="com.test.messaging.MessageService" />

This is the config you have given, you haven't got the property sub element to set the messageService attribute. So you'll not get anything if you remove the @Autowire

Secondly, this is not a spring integration question and is a basic Spring dependency injection query. Also you have posted this

private ImessageService messageService;

        public void setMessageService(imessageService args)
        {
          this.messageService = args;
        }

     public imessageService getMessageService()
        {
         return  this.messageService;
        }

This will never get compiled, please take your time and frame the question correctly and try to convey maximum possible information.

Let us know if it helps sort your issue..