IdGeneratorConfigurer causes 'Context initialization failed'

[dhs]

Hello,

I am testing to see if spring-integration (Version 2.1.0) could help me with a problem.

But, as how it is now, IdGeneratorConfigurer causes a 'Context initialization failed' i.e. if any bean class can not be found. We have a big project and this can occur...

Problem seems to to be the following line in IdGeneratorConfigurer:

boolean contextHasIdGenerator = context.getBeanNamesForType(IdGenerator.class).length > 0;

if I change it to:

boolean contextHasIdGenerator = context.getBeanNamesForType(IdGenerator.class, false, false).length > 0;

everything works fine. Is it a bug?

[Cleric]

Hello.

Can you show more info?
StackTrace, Spring version, environment etc.

Artem Bilan

[dhs]

Versions:
Spring 3.1
Spring-integration 2.1.0

It is a very big project with a many declared beans. It is at all times possible that there are bean definitions of beans that can't be instantiated (no class, error on constructing, ...). We can't avoid that. Parts of our software will not work, yes, but the rest can ignore that.

But with using Spring integration (IdGeneratorConfigurer) I can not even start the application because it will 'test' all defined beans...

I hope it is getting more clear what I mean (?)

--
Thanks,
Dennis Hoersch

[Cleric]

Ok.
I may assume the problem is in

context.getBeanNamesForType(IdGenerator.class, false, false)

on last argument allowEagerInit and it throws CannotLoadBeanClassException.
Can you play with true/false for this argument?

If it is that the issue is in Spring Core, but no Spring Integration.

Cheers,
Artem

[dhs]

The original code in IdGeneratorConfigurer is:

context.getBeanNamesForType(IdGenerator.class)

which calls

context.getBeanNamesForType(IdGenerator.class, true, true)

which causes an inspect of all beans.

I tested also:

context.getBeanNamesForType(IdGenerator.class, true, false)

this works well...
So the question is, is it necessary to enable allowEagerInit in IdGeneratorConfigurer?

--
Dennis

[Cleric]

Can you open an issue in JIRA and we will think about it ...

Thanks

[Cleric]

Dennis, please read my comment in the JIRA: https://jira.springsource.org/browse/INT-2410.
And try to fix problems with beans in your project.

Good luck

[dhs]

Hi Artem, I read and commented it too

[Cleric]

Hi, Dennis!

Please, let continue to discuss here.

Can you debug you application's start up and look for what's going on in the DefaultListableBeanFactory#getBeanNamesForType on IdGeneratorConfigurer#onApplicationEvent?
What causes a CannotLoadBeanClassException?

[dhs]

I have no access to my workspace from home, so I will debug it on monday.

But what I can remember is that if allowEagerInit is true getBeansOfType will rethrow the CannotLoadBeanClassException instead of silently ignore that. getBeansOfType does this for all beans, not only for those of the given type... (but of what should he know that the not loadable class is of some type ;-))