Unable to get request attributes in formView of SimpleForm

[moorthi]

BrandReviewController extends AbstractCommandController
BrandEditController  extends SimpleFormController
BrandAddController extends SimpleFormController

<bean id="brandReviewController"
	class="com.web.mvc.BrandReviewController">
	<property name="commandName"><value>brandCommand</value></property>
	<property name="commandClass"><value>com.web.mvc.BrandCommand</value></property>
</bean>
	
<bean id="brandEditController"
 		class="com.web.mvc.BrandEditController">
 		<property name="commandName"><value>brandCommand</value></property>
   		<property name="commandClass"><value>com.web.mvc.BrandCommand</value></property>
 		<property name="validator"><ref bean="brandAddValidator"/></property>
 		<property name="formView"><value>brandEditDef</value></property>
 		<property name="successView"><value>brandReviewDef</value></property>
</bean>

Flow:

1) Click Brand Link in main page --> 2) BrandReviewController (Load Brand Data) --> 3) brand_review.jsp (display brand data loaded in step2)
--> 4) Click on Edit button in brand_review.jsp --> 5) navigate to brand_edit.jsp (using formView property of brandEditController)


Data bound (using spring:bind) in step4 ie. in brand_review.jsp is not able obtain in step 5 ie.brand_edit.jsp.

I'm not submitting the form in step4. just clicking the button link <a href>

Am I missing something here?? Do I need to submit the FORM in step 4??

Thanks,
Moorthi

[irbouho]

Moorthi,

can you expand more on what data you send using your link, how your do to populate the data in brandEditController and what you put in your model before forwarding to the jsp?

[moorthi]

Hi Omar,

In brand_review.jsp, I am binding brandCommand.brand.brandNo value. This binding is done based on the radio button (next to each brandNo) selection by the user. After choosing the radio button, when user clicks on button link (not submiting form) request is handled by (brandReview.do - brandEditController).

protected Object formBackingObject(HttpServletRequest request) throws Exception {

	log.debug("formBackingObject : enter");

	if(!isFormSubmission(request)){
		String param = request.getParameter("selectedBrandNo");
		BrandCommand brandCommand = (BrandCommand)getCommand(request);

		if(brandCommand != null){
			String brandNo = brandCommand.getBrand().getBrandNo();
			log.debug("formBackingObject = "+brandNo);
		}else{
			brandCommand = new BrandCommand();				//line - 27
			if(param != null){
				brand.setBrandNo(param);
				brandCommand.setBrand(brand);
			}
		}
		return brandCommand;
	}else {
		return new BrandCommand();
	}
	
}

Inside brandEditController, i'm overriding formBackingObject(HttpServletRequest request) in which i'm checking for isFormSubmission(request) and trying to get the brandCommand object (using getCommand()) that I bound in brand_review.jsp. For some reason I'm not able to get the command object here. (I guess calling getCommand is not appropriate..)

Default implementation of formBackingObject always return new command object. But I want the existing command object with brandNo value in it.

If I pass brandNo as a param-value, i'm able to get it using request.getParameter("param") [see line 27] and instantiate new brandCommand object. In formView (brand_edit.jsp) I'm able to get the brandCommand.brand.brandNo value. But I would prefer to use my existing brandCommand object instead of re-populating the value. Is this possible??

Moorthi

[irbouho]

Moorthi,

add the following to your controller configuration:

  <property name="bindOnNewForm">
    <value>true</value>
  </property>

HTH

[moorthi]

Hi Omar,

I added "bindOnNewForm" property for my controller.

<bean id="brandEditController"
 		class="com.web.mvc.BrandEditController">
 		<property name="commandName"><value>brandCommand</value></property>
   		<property name="commandClass"><value>com.web.mvc.BrandCommand</value></property>
 		<property name="sessionForm"><value>true</value></property>
 		<property name="validator"><ref bean="brandAddValidator"/></property>
 		<property name="formView"><value>brandEditDef</value></property>
 		<property name="successView"><value>brandReviewDef</value></property>
 		<property name="bindOnNewForm"><value>true</value></property>
</bean>

calling getCommand(request) in formBackingObject(HttpServletRequest request) of my controller throws "Form object not found in session" exception msg.

javax.servlet.ServletException: Form object not found in session
	at org.springframework.web.servlet.mvc.AbstractFormController.getCommand(AbstractFormController.java:333)
	at com.web.mvc.BrandEditController.formBackingObject(BrandEditController.java:49)
	at org.springframework.web.servlet.mvc.AbstractFormController.getErrorsForNewForm(AbstractFormController.java:295)
	at org.springframework.web.servlet.mvc.AbstractFormController.showNewForm(AbstractFormController.java:277)
	at org.springframework.web.servlet.mvc.AbstractFormController.handleRequestInternal(AbstractFormController.java:233)
	at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:128)
	at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:44)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:584)
	at org.springframework.web.servlet.FrameworkServlet.serviceWrapper(FrameworkServlet.java:366)
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:317)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:740)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
	at weblogic.servlet.internal.ServletStubImpl$ServletInvocationAction.run(ServletStubImpl.java:996)
	at weblogic.servlet.internal.ServletStubImpl.invokeServlet(ServletStubImpl.java:419)
	at weblogic.servlet.internal.ServletStubImpl.invokeServlet(ServletStubImpl.java:315)
	at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:6452)
	at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321)
	at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:118)
	at weblogic.servlet.internal.WebAppServletContext.invokeServlet(WebAppServletContext.java:3661)
	at weblogic.servlet.internal.ServletRequestImpl.execute(ServletRequestImpl.java:2630)
	at weblogic.kernel.ExecuteThread.execute(ExecuteThread.java:219)
	at weblogic.kernel.ExecuteThread.run(ExecuteThread.java:178)

Then I tried to override getFormSessionAttributeName() method to get proper command name.

protected String getFormSessionAttributeName() {
			return isSessionForm() ? getCommandName() : null;
	}

Now I'm able to get the brandCommand object from session, but without the brandNo value that I bound in jsp (using spring:bind). Am I missing something??

Moorthi