problem getting dataSource using ClassPathXmlApplicationContext

[uzor]

Hi, I would like execute and jdbctemplate from a java class, to do that i get the datasource from a bean, the problem is that the properties of my datasource comes from a file.

java class:

ApplicationContext ac = new ClassPathXmlApplicationContext("classpath:datasource.xml");
    	DataSource datasource = (DataSource) ac.getBean("dataSource");

bean:

<bean id="dataSource" class="org.apache.commons.dbcp.BasicDataSource" >
		<property name="driverClassName" value="${database.driverClassName}" />
		<property name="url" value="${database.url}" />
		<property name="username" value="${database.username}" />
		<property name="password" value="${database.password}" />
	</bean>

error:

CannotGetJdbcConnectionException: Could not get JDBC Connection; nested exception is org.apache.commons.dbcp.SQLNestedException: Cannot load JDBC driver class '${database.driverClassName}'

any solution provided by Spring? thx!

[Marten Deinum]

And why should spring do anything here? Make sure that there is a PropertyPlaceHolderConfigurer configured and that the placeholders are available as properties. If they aren't it isn't going to work.

[uzor]

done!

XmlBeanFactory factory = new XmlBeanFactory(new FileSystemResource("beans.xml"));

// bring in some property values from a Properties file
PropertyPlaceholderConfigurer cfg = new PropertyPlaceholderConfigurer();
cfg.setLocation(new FileSystemResource("jdbc.properties"));

// now actually do the replacement
cfg.postProcessBeanFactory(factory);

DataSource datasource = (DataSource) factory.getBean("dataSource");

[Marten Deinum]

No No No...

Configure the PropertyPlaceholderConfigurer in the application context. I suggest a a read of the reference guide regarding the PropertyPlaceholderConfigurer.