Quartz doesn't shutdown

[roncox]

Spring 2.0.2
Quartz 1.6.0
Tomcat 5
JDK 1.4.2_11

I'm using Quartz in my web app. When I attempt to shutdown Tomcat, the Quartz threads don't shutdown. Here's my config:

<beans>

<bean name="logCacheStatisticsJob" class="org.springframework.scheduling.quartz.JobDe tailBean">
<property name="jobClass" value="com.metavante.its.services.scheduling.quart z.LogCacheStatisticsJob" />
<property name="jobDataAsMap">
<map>
<entry key="cacheRegistry">
<ref bean="cacheRegistry"/>
</entry>
</map>
</property>
</bean>

<bean id="cacheStatisticsCronTrigger" class="org.springframework.scheduling.quartz.CronT riggerBean">
<property name="jobDetail" ref="logCacheStatisticsJob" />
<!-- Every 2 minutes -->
<property name="cronExpression" value="0 0/2 * * * ?" />
<!-- Every 15 minutes -->
<!-- <property name="cronExpression" value="0 0,15,30,45 * * * ?" /> -->
</bean>

<bean class="org.springframework.scheduling.quartz.Sched ulerFactoryBean" destroy-method="destroy">
<property name="triggers">
<list>
<ref bean="cacheStatisticsCronTrigger" />
</list>
</property>
</bean>

</beans>

I looked at the source code for Spring's SchedulerFactoryBean and I see where the scheduler should be shutting down, but it's not happening.

/**
* Shut down the Quartz scheduler on bean factory shutdown,
* stopping all scheduled jobs.
*/
public void destroy() throws SchedulerException {
logger.info("Shutting down Quartz Scheduler");
this.scheduler.shutdown(this.waitForJobsToComplete OnShutdown);
}


Any ideas how I can fix this?

[karldmoore]

Is there anything in the log to detail what it's doing? Have you tried attaching a remote debugger and having a look what the active threads are doing?

[Rasool]

Hope the above code will do the work..

<bean id="scheduler" class="org.springframework.scheduling.quartz.SchedulerFactoryBean">
	<property name="triggers">
		<list>
			<ref bean="TRIGGER" />
		</list>
	</property>

	<property name="autoStartup"><value>true</value></property>
	<property name="applicationContextSchedulerContextKey"><value>applicationContext </value></property>
	<property name="waitForJobsToCompleteOnShutdown"><value>false</value></property>
</bean>

Regards,
I.N.

[karldmoore]

waitForJobsToCompleteOnShutdown=false is the default, not sure how that will help.

[jasone]

Hi, I recently ran into this problem.
I'm using the quartz.SchedulerFactoryBean but I'm not using the standard web contextloader, instead I'm using ClassPathXmlApplicationContext from my own singleton instantiated from my own servlet in order to get spring up.
I'm doing this because my code can then easilly be all packed up into a jar file and used in a servlet container or as a standalone app very easilly. as a standalone app quartz shuts down properly and the app finishes when main exits, but under tomcat it will not shutdown due to quartz. To solve this I had to implement the servlet destroy() method and physically shutdown the quartzscheduler
eg (simplified):
Scheduler sched= (Scheduler)ctx.getCtx().getBean("quartzSchedulerFa ctory");
sched.shutdown(false);

This works perfectly and allows tomcat to shutdown cleanly, but shouldnt spring be able to shutdown quartz by itself in this case?
Am I missing something or is this a bug?

[karldmoore]

This works perfectly and allows tomcat to shutdown cleanly, but shouldnt spring be able to shutdown quartz by itself in this case?

As far as I can see, it would be doing this already. The factory bean implements DisposableBean and this calls scheduler.shutdown().

[jasone]

As far as I can see, it would be doing this already. The factory bean implements DisposableBean and this calls scheduler.shutdown().

I agree it should - but it doesnt. this is my singleton(simplified):
public class SpringAppContainer {
private static SpringAppContainer instance;
private ApplicationContext ctx = null;
private SpringAppContainer() {
super();
}

public static synchronized SpringAppContainer getInstance()
{
if (instance == null) {
try {
instance = new SpringAppContainer();
instance.ctx = new ClassPathXmlApplicationContext("classpath*:au/mypackage/....../applicationContext*.xml");
}
catch (Exception e)
{
..
}
}
return instance;
}

public ApplicationContext getCtx() {
return ctx;
}
}

and I instantiate it in a servlet eg:
public class MyServlet extends HttpServlet {
private static SpringAppContainer ctx=SpringAppContainer.getInstance();
...

so now spring is up doing its thing, quartz is configured etc and all is well, but I cant shutdown tomcat without explicitly shutting down the scheduler, and I've tried it on Windows, linux, and Solaris
I tried everything from the latest version of spring and quartz to various 1.x versions of spring because according to some message threads I found, there had existed in some previous versions of spring a suspiciously similar problem that was alleged to be fixed since 1.5. I suspect spring will shutdown properly if I were to use the ContextLoaderServlet or the listener -perhaps it does something to initialise proper shutdown of spring?

[karldmoore]

Have a look at "3.5.1.2.2. Shutting down the Spring IoC container gracefully in non-web applications", just above the link below.
http://www.springframework.org/docs/...-factory-aware

[jasone]

I have no problem in a standalone - no web app. That ref is specifically for non-web containers - quote:

Note
This next section does not apply to web applications (in case the title of this section did not make that abundantly clear). Spring's web-based ApplicationContext implementations already have code in place to handle shutting down the Spring IoC container gracefully when the relevant web application is being shutdown.

[jasone]

but I guess if I'm not using a "real" web-based applicationcontext I should use this?

THanks.