[bug] jsf managed bean generation fail (because of bad collection naming strategies?)

[Dr.Drane]

I always tend to name my collection instance variable names after their type (e.g. Set<Address> addressSet = new HashSet<Address>(); ) instead of using a plural "-es" like suffix, which I think has a lot less sense (e.g. because of the nesting possibilities of groups).

A while ago I was astonished to notice Spring using the plural suffix naming strategy for generating names, as it doesn't feel like good practice, and now I stumbled upon bugs I think are caused by this strategy.

My domain model object:

@RooJavaBean
@RooToString
@RooJpaActiveRecord
public class Person extends AbstractEntity {

    private String firstName;

    private String name;

    private String initials;

    @ManyToOne
    private Nationality nationality;

    @ManyToMany(cascade = CascadeType.ALL)
    private Set<TradLanguage> languagueSet = new HashSet<TradLanguage>();

    @ManyToMany(cascade = CascadeType.ALL)
    private Set<Address> addressSet = new HashSet<Address>();

    @ManyToMany(cascade = CascadeType.ALL)
    private Set<PhoneNr> phoneNrSet = new HashSet<PhoneNr>();
}

generated PersonBean_Roo_ManagedBean.aj contains non-existing method names:

    public java.lang.String PersonBean.onEdit() {
        if (person != null && person.getTradLanguages() != null) {
            selectedLanguagueSet = new ArrayList<TradLanguage>(person.getLanguagueSet());
        }
        if (person != null && person.getAddresses() != null) {
            selectedAddressSet = new ArrayList<Address>(person.getAddressSet());
        }
        if (person != null && person.getPhoneNrs() != null) {
            selectedPhoneNrSet = new ArrayList<PhoneNr>(person.getPhoneNrSet());
        }
        return null;
    }

and

   
    public void CompanyBean.reset() {
        company = null;
        selectedTradLanguages = null;
        selectedAddresses = null;
        selectedPhoneNrs = null;
        createDialogVisible = false;
    }

while the declarations read:

    private List<TradLanguage> CompanyBean.selectedLanguagueSet;
    
    private List<Address> CompanyBean.selectedAddressSet;
    
    private List<PhoneNr> CompanyBean.selectedPhoneNrSet;

So the method names in red are generated incorrectly as opposed by the green method names.

Do I create a Jira for this?

Best wishes,

Jochen

EDIT: I've found a similar though different code generation issue:

In my model I have 2 collections of street objects:

    @ManyToMany(cascade = CascadeType.ALL)
    private Set<Street> rightfulStreets = new HashSet<Street>();

    @ManyToMany(cascade = CascadeType.ALL)
    private Set<Street> parkStreets = new HashSet<Street>();

in the generated xxxBean_Roo_ManagedBean.aj it correctly generated:

    private List<Street> AreaBean.selectedRightfulStreets;
    
    private List<Street> AreaBean.selectedParkStreets;

though in these places it fails:

public void AreaBean.reset() {
        area = null;
        selectedStreets = null;
        selectedStreets = null;
        createDialogVisible = false;
    }

and

    public java.lang.String AreaBean.onEdit() {
        if (area != null && area.getStreets() != null) {
            selectedRightfulStreets = new ArrayList<Street>(area.getRightfulStreets());
        }
        if (area != null && area.getStreets() != null) {
            selectedParkStreets = new ArrayList<Street>(area.getParkStreets());
        }
        return null;
    }

[Alan Stewart]

Raise an issue but please attach a Roo script to reproduce so I can reproduce it.

[Dr.Drane]

done!

https://jira.springsource.org/browse/ROO-2940

[Alan Stewart]

Resolved
Alan