Contribute some new adapter code to Spring integration.

[Amol Nayak]

Hello,
I have got some Amazon AWS spring integration adapters developed for
Amazon S3 (inbound and outbound), Amazon SES (outbound) and Amazon SQS (inbound and outbound). These adapters are developed with respective namespace support and successfully run for some basic test cases i have developed.

I have already signed this contract and have sent a scanned signed copy to the mentioned email id (I am yet to send the hard copy of the signed agreement though).

Can anybody tell me whom should I get in touch with or anything i am expected to do?

[Amol Nayak]

Can any of the moderators please throw some light on this?

[Mark Fisher]

We are working on setting up an extensions repository, and I will keep you posted on that.

In the meantime, is your code in github, and if so, would you mind sharing the URL?

[Amol Nayak]

Thanks Mark
I have it in my svn repository currently, i'll put it up on github and post the link here in few hours.

[Amol Nayak]

Hi Mark,
I have added the code to the github and it can be found here

There is a small getting started doc i have added to the docs folder (also attaching the .doc format )

[Amol Nayak]

Hi Mark,
Have you got a chance to have look at this one?
Also tentatively when would the extension repository be setup?

[Mark Fisher]

Amol,

Thanks for the reminder. I've been a bit overwhelmed getting 2.1 ready recently, but I will finally take a look (and will forward it to some other interested parties).

Keep an eye out for the extensions updates...

Thanks,
Mark

[Amol Nayak]

Thanks Mark , let me know your views/suggestions for it.

[Amol Nayak]

Hello Mark,
Apologies for digging out the old thread again. but did you get a chance to have a look, would like your feedback and suggestions to make some more changes to improve its usability.
Also, any news about the extension adapters repository?

[mrfritz379]

Hi Amol

Just wanted to leave some feedback on your AWS library. It's very handy and easy to add into our configuration, but ultimately we were unable to use it for a number of reasons.

• For various reasons, we cannot upgrade to Spring 3.1, but for some reason, your SQS adapter uses a ConversionService implementation only available in 3.1. I don't know why your SQS adapter needs to handle any conversion at all. Isn't that the job of Message Transformers?
• While the XML configuration offered by your XSD makes dropping in the functionality very simple, it does not allow for overriding various components. It would be great if I could just point it to a reference of my sqsClient, which might be a slightly different implementation rather than the default (add encryption, etc.). Also, you use a default Json message transformer, but don't have the configuration in place to use a different message transformer, or even customize the configuration of the Json transformer. We have some Jackson modules that are necessary to serialize/deserialize our data, but we can't add that in with the XSD configuration.
• I'm not sure why you need to use your own interface to describe the AwsCredentials. AwsCredentials is already an interface for which there are multiple implementations. We have one that retrieves our credentials from a secure store, but can't use it with your library because it doesn't implement your interface.

Ultimately, I think your components need to focus on doing fewer things. Ideally, the SQS adapters should just focus on dealing with the SQS data and delegating to any configurable transformers to manage serializing/deserializing the data. Some configuration like the following would be a great improvement:

    <!-- only one of credentialsRef or sqsClient is necessary -->
    <aws-sqs:inbound-channel-adapter
        credentialsRef="myCredentialsImpl" 
        sqsClient="myClientImpl"
        channel="inboundChannel"
        sqs-queue="https://queue.amazonaws.com/myworkqueue"
        transactional="false"
        max-redelivery-attempts="3">
            <int:poller fixed-rate="500" receive-timeout="3000" />
            <!-- optional transformer or transformation could be handled in the delegate channel chain -->
            <int:json-to-object-transformer type="com.foo.MyDataClass" object-mapper="objectMapper"/>
    </aws-sqs:inbound-channel-adapter>

Please keep working on the library, as I think it would be a great extension to SpringIntegration. The transaction support is nice and the option to use SES is also really cool. SNS would be a nice addition to round out the AWS messaging services available.

Thanks,

Mike