Spring Roo 1.2.0.M1 BUILD FAILURE: - Project (windows) cfa77e9 [FIXED]

[jbbarquero]

Hello:

I have a failure in Windows building for source the last commit: cfa77e954710544eddd0e78f41d2879969242e3d ROO-516: JSF 2.0 Addon (Date: Thu Sep 22 21:14:40 2011 +1000)

Here is my environment:

C:\...\git\spring-roo>mvn -version
Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100)
Java version: 1.6.0_22, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_22\jre
Default locale: es_ES, platform encoding: Cp1252
OS name: "windows vista", version: "6.0", arch: "amd64", family: "windows"

Here is the org.springframework.roo.project.MavenProjectMetada taProviderTest.txt at surefire-reports:

-------------------------------------------------------------------------------
Test set: org.springframework.roo.project.MavenProjectMetadataProviderTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.172 sec <<< FAILURE!
testRemoveDependencyTwiceWhenItExistsOnce(org.springframework.roo.project.MavenProjectMetadataProviderTest)  Time elapsed: 0.149 sec  <<< FAILURE!
Argument(s) are different! Wanted:
mockFileManager.createOrUpdateTextFileIfRequired(
    "/any/old/path",
    "<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<project>    <dependencies>
        <dependency>
            <groupId>com.example</groupId>
            <artifactId>test-lib</artifactId>
            <version>2.0.Final</version>
            <scope>test</scope>
        </dependency>
    </dependencies>
</project>
",
    <any>,
    false
);
-> at org.springframework.roo.project.MavenProjectMetadataProviderTest.testRemoveDependencyTwiceWhenItExistsOnce(MavenProjectMetadataProviderTest.java:111)
Actual invocation has different arguments:
mockFileManager.createOrUpdateTextFileIfRequired(
    "/any/old/path",
    "<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<project>    <dependencies>
        <dependency>
            <groupId>com.example</groupId>
            <artifactId>test-lib</artifactId>
            <version>2.0.Final</version>
            <scope>test</scope>
        </dependency>
    </dependencies>
</project>
",
    "removed dependency com.example:foo-lib:1.0.Final:exe",
    false
);
-> at org.springframework.roo.project.MavenProjectMetadataProvider.removeDependencies(MavenProjectMetadataProvider.java:350)

	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
	at org.springframework.roo.project.MavenProjectMetadataProviderTest.testRemoveDependencyTwiceWhenItExistsOnce(MavenProjectMetadataProviderTest.java:111)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:69)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:292)
	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
	at $Proxy0.invoke(Unknown Source)
	at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
	at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)

Thanks.

[jbbarquero]

Hello:

In MAC this test doesn't fail. Environment:

Javier-Beneito-Barqueros-MacBook-Pro:~ jbbarquero$ mvn --version
Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
Maven home: /usr/share/maven
Java version: 1.6.0_26, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.6.8", arch: "x86_64", family: "mac"

However in Windows it still fails, in spite the update of today:

commit bcebe5e3b0abdc36b26f6b7fda4ef68cd03bb495
Date:   Fri Sep 23 22:09:30 2011 +1000

Please note that the final result is different in some weird characters: "\u001b[36mremoved dependency\u001b[0m com.example:foo-lib:1.0.Final:exe",

I saw that the MavenProjectMetadataProvider.removeDependencies(.. ) method obtain a String message at line 347 that seems to be incorrect in windows. Maybe due to the call to the call to the static method AnsiEscapeCode.decorate(..) in the MavenProjectMetadataProvider's static method highlight(..).

It's possible to see a lot of weird character in Windows (like the [B]"\u001b[\B])

For now, I can't see what happens in the enhancement mockito implementation of the FileManager that currently writes the pom using the createOrUpdateTextFileIfRequired method(String, String, String, boolean).

I hope it helps a little.

[Andrew Swan]

This is logged as ROO-2773, which I have now resolved. Please retest on Windows and let me know how it goes.

[RogerPf]

I know I am not the OP but FYI, ROO is now building OK here on windows - commit ad17fadd - which is current last commit and is the one after the fix added above.

[Andrew Swan]

Thanks for letting me know, Roger!

[jbbarquero]

BUILD SUCCESS

In windows and MAC. I've used the commit e5a3cf86ad74d16623f946de22f00b37f9211665.

Thank you very much and good job!