ConcurrentModificationException + RefreshableValueHolder

**afida** · Nov 10th, 2004, 05:41 AM

I have a Wizard with a one WizardPage and a Form. It use to work fine but i have updated to new spring lib and I am starting to get some really strange errors.

I have a RefreshableValueHolder that updates ComboBox items on show(). As the model is changing so I need to update combobox model.

Following is the exception that Iam getting on wizard.execute().

Code:

03&#58;39&#58;51,448 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Setting newly selected item on value holder to Accounting

03&#58;39&#58;51,448 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Notifying combo box view selected value changed; new value is 'Accounting'

03&#58;39&#58;51,498 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Firing contents change event; selected item may have changed

03&#58;39&#58;51,498 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Returning selected item Accounting

03&#58;39&#58;51,498 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Returning selected item Accounting

03&#58;39&#58;51,498 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Returning selected item Accounting

03&#58;39&#58;51,498 DEBUG &#91;org.springframework.richclient.list.DynamicComboBoxListModel&#93; Fired contents change event!

03&#58;39&#58;51,508 ERROR &#91;org.springframework.richclient.application.config.ApplicationAdvisor&#93; 

java.util.ConcurrentModificationException

	at java.util.LinkedHashMap$LinkedHashIterator.nextEntry&#40;LinkedHashMap.java&#58;354&#41;

	at java.util.LinkedHashMap$KeyIterator.next&#40;LinkedHashMap.java&#58;365&#41;

	at org.springframework.binding.value.support.AbstractValueModel.fireValueChanged&#40;AbstractValueModel.java&#58;64&#41;

	at org.springframework.binding.value.support.BufferedValueModel.onWrappedValueChanged&#40;BufferedValueModel.java&#58;82&#41;

	at org.springframework.binding.value.support.BufferedValueModel$WrappedModelValueChangeHandler.valueChanged&#40;BufferedValueModel.java&#58;70&#41;

	at org.springframework.binding.value.support.AbstractValueModel.fireValueChanged&#40;AbstractValueModel.java&#58;64&#41;

	at org.springframework.binding.value.support.PropertyAdapter$DomainObjectChangeHandler.valueChanged&#40;PropertyAdapter.java&#58;70&#41;

	at org.springframework.binding.value.support.AbstractValueModel.fireValueChanged&#40;AbstractValueModel.java&#58;64&#41;

	at org.springframework.binding.value.support.ValueHolder.setValue&#40;ValueHolder.java&#58;52&#41;

	at org.springframework.binding.form.support.AbstractFormModel.setFormObject&#40;AbstractFormModel.java&#58;69&#41;

	at org.springframework.richclient.forms.CompoundForm.setFormObject&#40;CompoundForm.java&#58;55&#41;

	at com.vaau.rbacx.client.ui.view.businessunitsview.NewNewBusinessUnitWizard.execute&#40;NewNewBusinessUnitWizard.java&#58;53&#41;

	at com.vaau.rbacx.client.ui.view.businessunitsview.NewNewBusinessUnitWizard.execute&#40;NewNewBusinessUnitWizard.java&#58;61&#41;

	at org.springframework.richclient.command.TargetableActionCommand.doExecuteCommand&#40;TargetableActionCommand.java&#58;97&#41;

	at org.springframework.richclient.command.ActionCommand.execute&#40;ActionCommand.java&#58;188&#41;

	at org.springframework.richclient.command.ActionCommand$1.actionPerformed&#40;ActionCommand.java&#58;123&#41;

	at javax.swing.AbstractButton.fireActionPerformed&#40;AbstractButton.java&#58;1764&#41;

	at javax.swing.AbstractButton$ForwardActionEvents.actionPerformed&#40;AbstractButton.java&#58;1817&#41;

	at javax.swing.DefaultButtonModel.fireActionPerformed&#40;DefaultButtonModel.java&#58;419&#41;

	at javax.swing.DefaultButtonModel.setPressed&#40;DefaultButtonModel.java&#58;257&#41;

	at javax.swing.AbstractButton.doClick&#40;AbstractButton.java&#58;289&#41;

	at javax.swing.plaf.basic.BasicMenuItemUI.doClick&#40;BasicMenuItemUI.java&#58;1113&#41;

	at javax.swing.plaf.basic.BasicMenuItemUI$MouseInputHandler.mouseReleased&#40;BasicMenuItemUI.java&#58;943&#41;

	at java.awt.Component.processMouseEvent&#40;Component.java&#58;5134&#41;

	at java.awt.Component.processEvent&#40;Component.java&#58;4931&#41;

	at java.awt.Container.processEvent&#40;Container.java&#58;1566&#41;

	at java.awt.Component.dispatchEventImpl&#40;Component.java&#58;3639&#41;

	at java.awt.Container.dispatchEventImpl&#40;Container.java&#58;1623&#41;

	at java.awt.Component.dispatchEvent&#40;Component.java&#58;3480&#41;

	at java.awt.LightweightDispatcher.retargetMouseEvent&#40;Container.java&#58;3450&#41;

	at java.awt.LightweightDispatcher.processMouseEvent&#40;Container.java&#58;3165&#41;

	at java.awt.LightweightDispatcher.dispatchEvent&#40;Container.java&#58;3095&#41;

	at java.awt.Container.dispatchEventImpl&#40;Container.java&#58;1609&#41;

	at java.awt.Window.dispatchEventImpl&#40;Window.java&#58;1590&#41;

	at java.awt.Component.dispatchEvent&#40;Component.java&#58;3480&#41;

	at java.awt.EventQueue.dispatchEvent&#40;EventQueue.java&#58;450&#41;

	at java.awt.EventDispatchThread.pumpOneEventForHierarchy&#40;EventDispatchThread.java&#58;197&#41;

	at java.awt.EventDispatchThread.pumpEventsForHierarchy&#40;EventDispatchThread.java&#58;150&#41;

	at java.awt.EventDispatchThread.pumpEvents&#40;EventDispatchThread.java&#58;144&#41;

	at java.awt.EventDispatchThread.pumpEvents&#40;EventDispatchThread.java&#58;136&#41;

	at java.awt.EventDispatchThread.run&#40;EventDispatchThread.java&#58;99&#41;

Here is my wizard.execute()

Code:

    public void execute&#40;&#41; &#123;
        if &#40;wizardDialog == null&#41; &#123;
            wizardDialog = new WizardDialog&#40;this&#41;;
            wizardDialog.setResetMessagePaneOnDisplay&#40;true&#41;;
            wizardForm = new CompoundForm&#40;&#41;;
        &#125;
        wizardForm.setFormObject&#40;new BusinessUnit&#40;&#41;&#41;;
        wizardDialog.showDialog&#40;&#41;;
    &#125;

Here is my form.createControl()

Code:

        protected JComponent createFormControl&#40;&#41; &#123;
            FormLayout layout = new FormLayout&#40;"left&#58;pref, 5dlu, pref&#58;grow"&#41;;
            JGoodiesBeanFormBuilder formBuilder = new JGoodiesBeanFormBuilder&#40;getFormModel&#40;&#41;, layout&#41;;
            businessUnitNameField =&#40;JTextField&#41; formBuilder.add&#40;"businessUnitName"&#41;&#91;1&#93;;
            refreshableValueHolder = new RefreshableValueHolder&#40;new Block&#40;&#41; &#123;
                public Object call&#40;Object object&#41; &#123;
                    return getFlattenedBusinessUnits&#40;&#41;;
                &#125;
            &#125;, true&#41;;

            parentBusinessUnitComboBox =
                getFormModel&#40;&#41;.createBoundComboBox&#40;"parentBusinessUnit", refreshableValueHolder, "businessUnitName"&#41;;

            formBuilder.getWrappedFormBuilder&#40;&#41;.add&#40;PARENT_BUSINESS_UNIT_LABEL_ID, parentBusinessUnitComboBox&#41;;
            return formBuilder.getForm&#40;&#41;;
        &#125;

I am going nuts over this, please any help will be really appreciated.

Amad

**pdbruycker** · Nov 10th, 2004, 06:23 AM

modify your getFlattenedBusinessUnits method so it returns a copy of your internal collection. (if it's a list do the following: return new ArrayList(internalList);

**afida** · Nov 10th, 2004, 11:20 AM

modify your getFlattenedBusinessUnits method so it returns a copy of your internal collection. (if it's a list do the following: return new ArrayList(internalList);

I have looked at my code and thats what I do already. Any ideas
Amad

**Keith Donald** · Nov 10th, 2004, 11:38 AM

Amad,

Are you spawning any other threads at all? Did you just synchronize today? Perhaps send me the code off-line I can take a look and add some tests.

**afida** · Nov 10th, 2004, 01:08 PM

Are you spawning any other threads at all?

No

Did you just synchronize today?

I had synchronized a week ago.

**snpe** · Nov 10th, 2004, 06:44 PM

Amad,
try with TableFormBuilder except Jgoodies

regards

**afida** · Nov 10th, 2004, 07:22 PM

snpe

try with TableFormBuilder except Jgoodies

Is there a TableBeanFormBuilder?

Amad[/quote]

**snpe** · Nov 10th, 2004, 07:44 PM

There is TableFormBuilder

see user documentation form support (it is on wiki)

It is new, JGoodiesBeanFormBuilder is deprecated

for table support exists BeanTableModel

regards

**Keith Donald** · Nov 10th, 2004, 07:44 PM

It's TableFormBuilder. See the latest petclinic snapshot for example usage.

Hey Amad, also try synchronzing with the latest snapshot to see if its still a problem.

Keith

**afida** · Nov 11th, 2004, 12:06 AM

I have got the latest build and now using TableFormBuilder. Problem still persists, I have commented out some code and here is the line the causing the problem,

Code:

getFormModel&#40;&#41;.createBoundComboBox&#40;selectionFormProperty, selectableItemsHolder, renderedItemProperty&#41;;

Because if I take it out, exception goes away! Any clues :idea:

Thread: ConcurrentModificationException + RefreshableValueHolder

Thread Tools

Display

ConcurrentModificationException + RefreshableValueHolder

Posting Permissions