Possible Bug in new Rules

[afida]

I have a rule define as following,

    private Rules createGlobalUserRules() {
        return new Rules(GlobalUser.class) {
            protected void initRules() {
                add("firstName", getNameValueConstraint());
                add("lastName", getNameValueConstraint());
                add(not(eqProperty("firstName", "lastName")));
            }
        };
    }

and then I have a GlobalUserForm which is an editor for GlobalUser domain object. But when I set a GlobalUser on editor by

globalUserEditorModel.setFormObject(selectedObject);

Event though the selected user has first name and last name which are not equal and have valid values, form still show error on these two fields and Apply button is not enabled. Now if i just add a space and then delete it or just delete the last character in firstName and type it again then everything is fine. Seems like my form is not getting validated correctly on setFormObject().

Amad

[Keith Donald]

Thanks Amad, good report. Will take a look at this promptly.

[Keith Donald]

Amad,

I am unable to recreate this issue quickly in petclinic...

Are you using the form in conjuction with a FormBackedDialogPage or FormBackedWizardPage? I had to put a temp workaround in those classes becaues validation during form model construction is now an manual process. This is because, for validation to work with properties that affect other properties, all properties must currently be present on the model first.

Try calling ValidatingFormModel.validate() manually after form model construction and see if that fixes the problem. After construction, setFormObject() should trigger a revalidate -- which it appears to be doing, Petclinic is working nicely. Take a look at FormBackedDialogPage's createControl method to see how i does it --

Above is a bandaid solution until I get a chance to do some refactoring--form models should really add property value models automatically, when needed, instead of manually. Expect tests to prove this is or is not working soon. :-)

[afida]

Keith,

I am using a CompoundForm in TabbedDialogPage (I don't have the code here so I don't remember the correct class name). I will try to call validate() manually as well.

Thanks

Amad

[afida]

As I mentioned i am using CompundFormModel in a TabbedDialogPage. I add forms to tabbedDialogPage and I set the FormObject on my compoundFormModel. As there is no way from TabbedDialogPage to validate all the forms it contains, I have added a FormObjectChangeListener and I call validate everytime there is valueChanged() called. It has fixed my problem but assuming that this is a quick work-around?

Amad

[Keith Donald]

Yes, this won't be required in the future.