Oracle Jdbc invalid url problem

[jfuchs]

Hallo,
I have a problem similar to the one described in this thread but I couldn't fix it so far.
http://forum.springframework.org/showthread.php?t=10870

I am running an application using Spring but no Hibernate on Tomcat 5. Using MySQL is no problem but trying to connect to an Oracle 10g database is impossible. I am using these connection details for my DataSource:

    	<property name="username"><value>user</value></property>
    	<property name="password"><value>pw</value></property>
    	<property name="url"><value>jdbc:oracle:thin:@servername:1521:teacup</value></property>
    	<property name="driver"><value>oracle.jdbc.driver.OracleDriver</value></property>

Running it on a desktop with W2k the log file shows an Invalid Jdbc Url error after displaying that spring obviously translated the url into
jdbc:oracle://servername:1521/teacup. Connecting to the database from the commandline is no problem using simple jdbc code.
When I try to run either the application or the little test program on the WinXP machine it says 'Io exception: The Network Adapter could not establish the connection'.
What is the problem? Is it ok that Spring changes the database url? If not, how can I prevent this? It's fine with MySQL but the application has to run with Oracle so I need to sort that out. Any ideas?
Thanks,
Joachim

[irbouho]

could you show how you access this datasource from Spring / Hibernate?

[jfuchs]

Hi,
I do nothing else than using code like this that I took from the Spring Reference Guide. I have 9 classes that act as mediators between the controllers and the database. Each of them has a few methods that contain this piece of code.

...
JdbcTemplate jt = new JdbcTemplate(dataSource);
String query = "...";
List l = jt.queryForList(query);
...

I don't use Hibernate since the application isn't that big and I don't have time to figure out how it goes. Is there any kind of configuration that I missed to use?
Cheers
Joachim

[jwray]

I connect to Oracle every day using the Spring configuration of the datasource and the thin drivers. I don't think Spring is your problem. Have you tryed configuring the datasource programatically thus ruling out Spring as the culprit?

I my experience, if I see an error like that, it's an Oracle networking problem. I never trust their error messages either, invariably they have no relation to the actual problem.

[jfuchs]

This is my data source, it is used as an attribute by every bean that has to talk to the database.
It is still not clear to me why a simple piece of 'classic'* jdbc code connects and the fancy spring does not.

package cms.data.db.oracle;

import java.sql.Connection;
import java.sql.DriverManager;

import java.sql.SQLException;

import javax.sql.DataSource;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

/**
 *
 * @author  jf
 */
public class OracleDataSource implements DataSource {
    
    private final Log logger = LogFactory.getLog(this.getClass());
    
    private String url = null;
    private String driver = null;

    private String username = null;
    private String password = null;
    
    public void setUsername(String username){
        this.username = username;
    }
    
    public String getUsername(){
        return this.username;
    }
    
    public String getPassword(){
        return this.password;
    }
    
    public void setPassword(String password){
        this.password = password;
    }
    
    public void setUrl(String url){
        this.url = url;
    }
    
    public String getUrl(){
        return this.url;
    }
    
    public void setDriver(String driver){
        this.driver = driver;
    }
    
    public String getDriver(){
        return this.driver;
    }
    
    /** Creates a new instance of OracleDataSource */
    public OracleDataSource() {
    }
    
    public Connection getConnection() throws SQLException {
        Connection result = null;
        try {
        Class.forName(getDriver());    
        }
        catch (ClassNotFoundException cnfe){
            logger.error(cnfe);
        }                
        result = DriverManager.getConnection(getUrl(), getUsername(), getPassword());
        return result;
    }
    
    public Connection getConnection(String username, String password) throws SQLException {
        this.username = username;
        this.password = password;
                
        return getConnection();        
    }
    
    public java.io.PrintWriter getLogWriter() throws java.sql.SQLException {
        throw new RuntimeException("not implemented");
    }
    
    public int getLoginTimeout() throws java.sql.SQLException {
        throw new RuntimeException("not implemented");
    }
    
    public void setLogWriter(java.io.PrintWriter out) throws java.sql.SQLException {
        throw new RuntimeException("not implemented");
    }
    
    public void setLoginTimeout(int seconds) throws java.sql.SQLException {
        throw new RuntimeException("not implemented");
    }
    
}

Cheers
Joachim


* classic =

...
url = System.getProperty("DB_URL");
db_driver = System.getProperty("DB_DRIVER");
Class.forName(db_driver); 
conn = DriverManager.getConnection(url,username,password);
...

[Colin Sampaleanu]

Spring is not going to change the URL on you. If you are passing in the URL as a string to a string property, it's going to stay exactly as you specified it. You could log from your DataSource class to verify this.

However, I'm confused as to why you are even rolling your own DataSource implementation. What you have right now looks pretty similar to DriverManagerDataSource, which comes with Spring, but I would personally, even for tests, just use DBCP from apache, which is trivial to set up and as a bean, and you'll get pooling, which your DataSource and DriverManagerDataSource don't offer.