Petclinic, date validation

[khem]

Hi,

I m learning to know how the petclinic web app and I ve a question. In the page addPet.htm, when I enter an invalid date, an error is display "invalid date". But I ve look into the validator which refers to this page (PetValidator.java) and there is no test for the date.

How and where this invalid date error is detected?

[irbouho]

khem,
AddPetForm.java (the form to witch /addPet.htm is mapped) extends AbstractClinicForm. The later registers a property editor for application's date format

	protected void initBinder(HttpServletRequest request, ServletRequestDataBinder binder) {
		SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
		dateFormat.setLenient(false);
		binder.registerCustomEditor(Date.class, null, new CustomDateEditor(dateFormat, false));
	}

This editor is used for converting to Date. The message you got "invalid date" is thrown whenever the editor fails to parse a date.

HTH

[khem]

Hi,

thx for your answer irbouho.
So if I understand, when the editor fails to parse the date, it throws an exception. Is this exception resolved automatically by the ResourceBundleMessageSource? Because in this file, I see this :

typeMismatch.date=invalid date
typeMismatch.birthDate=invalid date

Would that mean that when there s a type mismatch on a field called xxx, the error message that will be thrown will be the one defined in the ResourceBundleMessageSource which will looks like

typeMismatch.xxx=error message

?
What happend if there s no ResourceBundleMessageSource defined?

[nilesh]

If you don't have the message defined, you get a verbose error; for example, something like this (my field is called updateStamp):

Failed to convert property value of type [java.lang.String] to required type [java.util.Date] for property 'updateStamp'; nested exception is java.lang.IllegalArgumentException: Could not parse date: Unparseable date: "2004-092"

I came across this post http://forum.springframework.org/showthread.php?t=9576 which mentioned that having the declare all the properties can be cumbersome. I agree with that.. however, I found you can define a catch-all typeMismatch like this in your message bundle:

typeMismatch=Invalid type - {$0}

It catches all the cases where you haven't defined a message. The {$0} just gives you the property name (in my case "updateStamp") which isn't really useful, as that's often something that's not presentable to the user.

I would prefer a way to report errors based on the type of the property (as a fall-back when the specific property name isn't defined). For example, define a message specifically for java.util.Date, etc. Any ideas?

[nilesh]

Looks like there is a way to define messages that are displayed for specific types. For example:

typeMismatch.java.util.Date=Invalid date entry
typeMismatch.java.lang.Integer=Invalid integer entry

[hpaluch]

Looks like there is a way to define messages that are displayed for specific types. For example:

typeMismatch.java.util.Date=Invalid date entry
typeMismatch.java.lang.Integer=Invalid integer entry

Hi!
Exactly! There are more details in javadoc apis on: http://www.springframework.org/docs/...sResolver.html

[mragab]

I hade the same problem, I have tried customizing the error message in case of typeMismatch and it works fine.

Invalid date entry

But I still get the error message of the validation atfter that :!:

Invoice date is a required field.

Validation is not supposed to be done for a field with type mismatch. :?:

Note that the above is only displayed in case of binding all messages

<spring&#58;bind path="invoice.*">
    <c&#58;if test="$&#123;not empty status.errorMessages&#125;">
    <div class="error">	
        <c&#58;forEach var="error" items="$&#123;status.errorMessages&#125;">
            <c&#58;out value="$&#123;error&#125;" escapeXml="false"/><br />
        </c&#58;forEach>
    </div>
    </c&#58;if>
</spring&#58;bind>

But in case of binding only the message of invoice.date I only get the "Invalid date entry" message

<spring&#58;bind path="invoice.date">
	<input type="text" name="$&#123;status.expression&#125;" value="$&#123;status.value&#125;"/>
	<span class="fieldError">$&#123;status.errorMessage&#125;</span>
</spring&#58;bind>

But still, validation is done in both cases.