MVC tutorial and Validation

[nicklothian]

I'm trying to figure out how the spring validators are called.

In the MVC tutorial it shows how to wire up a Validator and a Controller.

That seems to work fine, but I can't figure out how the validator gets called.

The relevent part of the config file is

   
 <!--  Validator and Form Controller for the "Price Increase" page -->
    <bean id="priceIncreaseValidator" class="bus.PriceIncreaseValidator"/>
    <bean id="priceIncreaseForm" class="web.PriceIncreaseFormController">
        <property name="sessionForm"><value>true</value></property>
        <property name="commandName"><value>priceIncrease</value></property>
        <property name="commandClass"><value>bus.PriceIncrease</value></property>
        <property name="validator"><ref bean="priceIncreaseValidator"/></property>
        <property name="formView"><value>priceincrease</value></property>
        <property name="successView"><value>hello.htm</value></property>
        <property name="productManager">
            <ref bean="prodMan"/>
        </property>
    </bean>

Tracing through the Spring code, I think the validator gets called in the bindAndValidate method in BaseCommandController.

	/**
	 * Bind the parameters of the given request to the given command object.
	 * @param request current HTTP request
	 * @param command the command to bind onto
	 * @return the ServletRequestDataBinder instance for additional custom validation
	 * @throws Exception in case of invalid state or arguments
	 */
	protected final ServletRequestDataBinder bindAndValidate(HttpServletRequest request, Object command)
			throws Exception {
		ServletRequestDataBinder binder = createBinder(request, command);
		binder.bind(request);
		onBind(request, command, binder.getErrors());
		if (this.validators != null && isValidateOnBinding() && !suppressValidation(request)) {
			for &#40;int i = 0; i < this.validators.length; i++&#41; &#123;
				ValidationUtils.invokeValidator&#40;this.validators&#91;i&#93;, command, binder.getErrors&#40;&#41;&#41;;
			&#125;
		&#125;
		onBindAndValidate&#40;request, command, binder.getErrors&#40;&#41;&#41;;
		return binder;
	&#125;

As far as I can see isValidateOnBinding() will always return false, unless the validateOnBinding property is set to true in the confiig.

What am I missing?

[fmourioux]

Perhaps it is call by an interceptor before.

Fabien

[nicklothian]

No - there are no interceptors configured. The complete config file is available in the tutorial

[irbouho]

from BaseCommandController source

	private boolean validateOnBinding = true;


	/**
	 * Set if the Validator should get applied when binding.
	 */
	public final void setValidateOnBinding(boolean validateOnBinding) {
		this.validateOnBinding = validateOnBinding;
	}

	/**
	 * Return if the Validator should get applied when binding.
	 */
	protected final boolean isValidateOnBinding() {
		return validateOnBinding;
	}

if validateOnBinding is not set to false, isValidateOnBinding() always returns true.

[nicklothian]

I must have missed that.

Thanks