JtaTransactionManager depends on aopalliance.jar?

[timmorrow]

Not really a problem, I was just suprised to get the following error when using JtaTransactionManager programmatically with the following bean defintion (I only had spring.jar in my classpath):

<bean id="transactionManager" class="org.springframework.transaction.jta.JtaTran sactionManager" />

The error was:

org.springframework.beans.factory.BeanDefinitionStoreException: Error registering bean with name 'transactionManager' defined in class path resource [com/somepackage/ApplicationContext.xml]: Class that bean class [org.springframework.transaction.jta.JtaTransactionManager] depends on not found; nested exception is java.lang.NoClassDefFoundError: org/aopalliance/aop/AspectException
java.lang.NoClassDefFoundError: org/aopalliance/aop/AspectException
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:219)
        at org.springframework.beans.factory.support.BeanDefinitionReaderUtils.createBeanDefinition(BeanDefinitionReaderUtils.java:50)
...

I added aopalliance.jar to my classpath and it took care of the problem. Is it expected that this is a required dependency? Is it generally accepted that we should add all the supporting libs to the classpath, or just add them piecemeal as dependencies show themselves through errors like this?

Cheers,

Tim

[Loumeister]

I pretty much add them as needed due to the fact that we don't implement the whole spring framework. Like you, I needed to add the aopalliance.jar to use the interceptors, but that's been it so far.

Best,
Lou

[irbouho]

Loumeister & Loumeister,

To implement Transaction using AOP, TransactionProxyFactoryBean uses internaly a TransactionInterceptor. the later extends TransactionAspectSupport that has a method readObject used for serialization.

	private void readObject(ObjectInputStream ois) throws IOException {
		// Rely on default serialization, just initialize state after deserialization
		try {
			ois.defaultReadObject();
		}
		catch (ClassNotFoundException ex) {
			throw new AspectException("Failed to deserialize Spring AOP transaction aspect:" +
					"Check that Spring AOP libraries are available on the client side", ex);
		}
		
		// Initialize transient fields
		this.logger = LogFactory.getLog(getClass());
	}

Throwing a AspectException makes transaction management in Spring depends on aopalliance.jar.
I think this should be documented somewhere in Spring documentation and readme.txt (spring libraries dependencies)

[Juergen Hoeller]

In general, you need aopalliance.jar when working with Spring's AOP framework, whether directly or indirectly. However, JtaTransactionManager shouldn't depend on AOP Alliance: That has to be considered a bug. I've just fixed it: It was just an accidental use of the AOP Alliance AspectException that was straightforward to be replace.

Juergen

[irbouho]

Oups, I am sorry for the confusion, I was looking at two many classes in the same times.
indeed, JtaTransactionManager has a readObject method:

	private void readObject(ObjectInputStream ois) throws IOException {
		// rely on default serialization, just initialize state after deserialization
		try {
			ois.defaultReadObject();
		}
		catch (ClassNotFoundException ex) {
			throw new AspectException("Failed to deserialize JtaTransactionManager: " +
																"Check that JTA and Spring transaction libraries are available on the client side", ex);
		}
		// do client-side JNDI lookup
		this.jndiTemplate = new JndiTemplate();
		// run lookup code for UserTransaction
		this.userTransaction = lookupUserTransaction(this.userTransactionName);
	}

that depends on aopapplicane.jar

[Rod Johnson]

Sorry--my fault. Juergen's now fixed it for 1.1 final. Thanks for the feedback!

[timmorrow]

Now that's great service!

Cheers,

Tim