Roo 1.1.1 keeps regenerating pushed-in controller methods

[ccmtaylor]

In my Roo application, I need to add an additional parameter to the list method, so I pushed it in to my controller class:

@RooWebScaffold(path = "participants", formBackingObject = MyDomainClass.class)
@RequestMapping("/foo/{myPath}/")
class MyController {

    @RequestMapping(value="/", method = RequestMethod.GET, headers="Accept=text/html")
    public String list(
        @PathVariable String myPath,
        @RequestParam(value = "page", required = false) Integer page,
        @RequestParam(value = "size", required = false) Integer size, Model model) {
    ...
    }

}

Unfortunately, since version 1.1.1, Roo keeps re-generating the original list() method in MyController_Roo_Controller.aj, leading to a 500-errorpage with the following error message:

Ambiguous handler methods mapped for HTTP path '/foo/somepath': {public java.lang.String MyController.list(java.lang.Integer,java.lang.Integer,org.springframework.ui.Model), public java.lang.String MyController.list(java.lang.String,java.lang.Integer,java.lang.Integer,org.springframework.ui.Model)}.

Is there some way to prevent Roo from regenerating the method? This has only started happening since I upgraded to version 1.1.1.

Thanks,
--Chris

[Jack Punt]

maybe remove mypath form the Controller and apply to the method:

@RequestMapping("/foo")
class MyController {

@RequestMapping(value="/{myPath}", method = RequestMethod.GET, headers="Accept=text/html")

[ccmtaylor]

Jack, thanks for the response. My actual controller binds to a sub-path of the request mapping

@RequestMapping("/foo/{myPath}/bar")
class MyController

and there are other Controllers that are even more nested (e.g. /foo/{myPath}/bar/{myBar}/baz). If I changed all their paths to /foo, the Roo-generated methods now would all be ambiguous.

Also, the method would still have an extra parameter (which, I suspect, is the reason why Roo regenerates the scaffolded method(s)).

[Jack Punt]

Indeed, the generation is tied to the signature.
So push-in the signature that you want to stop generating,
and bind it to a path that will not conflict.

[Harald Walker]

I have the same problem. Almost all of my controllers with pushed-in methods are broken because ROO re-generated methods in the roo_controller.aj files since the update from 1.1.0 to 1.1.1. In this an intended change in behavior in 1.1.1 (issue #?) or should we consider it a bug?

[Harald Walker]

Indeed, the generation is tied to the signature.
So push-in the signature that you want to stop generating,
and bind it to a path that will not conflict.

Seems like pushing in and removing any request mapping is enough.

E.g. just:

public String createForm(Model model) {return null;} 

does the trick but it is not nice having these dummy methods in the controller.