trying to implement AOP with Spring

[musch]

I try to implement AOP with Spring, but it´s not work, my advise is not call, below is my code and my configuration.

agenciaServiceImpl is a Pojo, and work fine.

    <bean id="agenciaServiceImpl" class="com.teste.dao.AgenciaServiceImpl">
		<property name="agenciaDao"><ref bean="agenciaDao"/></property>	
		<property name="bancoDao"><ref bean="bancoDao"/></property>	
    </bean>

    <bean id="makeDaoLog" class="com.teste.util.MakeDaoLog" />

	<bean id="agenciaProxyBean" class="org.springframework.aop.framework.ProxyFactoryBean">
		<property name="proxyInterfaces">
			<value>com.teste.dao.IAgenciaService</value>
		</property>
		<property name="interceptorNames">
			<list>
				<value>makeDaoLog</value>
				<value>agenciaServiceImpl</value>
			</list>
		</property>
	</bean>

package com.teste.util;

import java.lang.reflect.Method;
import org.springframework.aop.MethodBeforeAdvice;

public class MakeDaoLog implements MethodBeforeAdvice {

	public void before(Method m, Object[] args, Object target) throws Throwable {
		System.out.println(" pass here ");
	}

}

[irbouho]

musch, can you show your client code, and the log result.

[musch]

in WebWork Action

			ApplicationContext ctx = WebApplicationContextUtils.getWebApplicationContext(ServletActionContext.getServletContext());
			AgenciaServiceImpl imp = (AgenciaServiceImpl) ctx.getBean("agenciaServiceImpl");
			imp.gravaAgencia(banco,agencia);

public class AgenciaServiceImpl implements IAgenciaService {
	
	private AgenciaDaoImpl agenciaDao;
	private BancoDaoImpl   bancoDao;
	
	public void gravaAgencia(Banco banco, Agencia agencia) {
		bancoDao.create(banco);
		agenciaDao.create(agencia);
	}

	public AgenciaDaoImpl getAgenciaDao() {
		return agenciaDao;
	}
	public void setAgenciaDao(AgenciaDaoImpl agenciaDao) {
		this.agenciaDao = agenciaDao;
	}
	public BancoDaoImpl getBancoDao() {
		return bancoDao;
	}
	public void setBancoDao(BancoDaoImpl bancoDao) {
		this.bancoDao = bancoDao;
	}
}

and none error is showing in TOMCAT console[/code]

[irbouho]

You must retrieve the advised bean in your code

AgenciaServiceImpl imp = (AgenciaServiceImpl) ctx.getBean("agenciaProxyBean"); 
         imp.gravaAgencia(banco,agencia);

"agenciaServiceImpl" is your base bean, if you get it from applicationContext, Spring will return an instance of your POJO.

"agenciaProxyBean" is "agenciaServiceImpl" wrapped by your advisor, so when you call methods of your bean, the advisor will kick and intercept the method call.

[bpolka]

I think you are confusing something here

AgenciaServiceImpl imp = (AgenciaServiceImpl) ctx.getBean("agenciaServiceImpl"); 
imp.gravaAgencia(banco,agencia);

You understand that this will get the bean that is not proxied at all, hence AOP is not working. What you probably mean to do is:

        AgenciaServiceImpl imp = (AgenciaServiceImpl) ctx.getBean("agenciaProxyBean"); 
         imp.gravaAgencia(banco,agencia);

note the bean name I retrieve from the application context has changed, now you are retrieving proxied bean that will apply interceptor code in the chain you specified.

HTH

[/code]

[musch]

I´m a idiot !!! :oops:

but u forget indicate interface
final solution

			ApplicationContext ctx = WebApplicationContextUtils.getWebApplicationContext(ServletActionContext.getServletContext());
			IAgenciaService imp = (IAgenciaService) ctx.getBean("agenciaProxyBean");
			imp.gravaAgencia(banco,agencia);

thanks

[Colin Sampaleanu]

Also, consider wrapping the target as an inner bean, with the proxy, so this sort of mistake can't happen. Generally, I only recommend keeping the target as a separate top-level bean if more than one other bean needs to refer to it (the unwrapped target).