PerformanceMonitorInceptor [Archive] - Spring Community Forums

chenrici

Jul 15th, 2005, 04:42 AM

i want to monitor different implementations of the same interface.
using the PerformanceMonitorInterceptor i am getting"only" the name of Interface logged.
Is it in any way possible to get the name of the implementing class?

best thanx for any advice.
Christoph

robh

Jul 15th, 2005, 10:58 AM

Christoph,

Can you post the configuration you are using to define the monitored proxies along with snippets of code for the objects being proxied.

Rob

chenrici

Jul 15th, 2005, 12:17 PM

Rob,

here a snippet from my configuration:

<bean id="rabattDao" class="com.apgsga.vk.preisermittlung.db.RabattDaoImpl">
<property name="dataSource">
<ref local="dataSource"/>
</property>
</bean>
<bean id="monitoredrabattDao"
class="org.springframework.aop.framework.ProxyFactoryBean">
<property name="proxyInterfaces">
<value>com.apgsga.vk.preisermittlung.db.ContextLoadingDao</value>
</property>
<property name="target">
<ref local="rabattDao"/>
</property>
<property name="interceptorNames">
<list>
<value>performanceMontitor</value>
</list>
</property>
</bean>

and the performance monitor:

<bean id="performanceMontitor"
class="org.springframework.aop.interceptor.PerformanceMon itorInterceptor">
</bean>

I have different Dao's like the one above (rabattDao) all implementing the same Interface.
My problem is that the name, which is logged is for all the same: the interface they implement.
I would actually like to see the class name of the target.

Christoph

robh

Jul 15th, 2005, 06:22 PM

Christoph,

Try setting the 'proxyTargetClass' property of ProxyFactoryBean to true.

Rob

chenrici

Jul 18th, 2005, 01:58 AM

Hi Rob,

somehow the bean's don't load after setting the proxyTargetClass in the ProxyFactoryBean to true.

I get the following exception stack:

[junit] 1) testService(com.apgsga.vk.preisermittlung.service. BatchServiceInterfaceImplTests)org.springframework .beans.factory.BeanCreationException: Error creating bean with name 'monitoredrabattDao' defined in class path resource [batchtestbeans.xml]: Initialization of bean failed; nested exception is org.aopalliance.aop.AspectException: null
[junit] java.lang.IllegalStateException: Callback Lnet/sf/cglib/proxy/MethodInterceptor; is not assignable to Lnet/sf/cglib/proxy/MethodInterceptor;
[junit] at net.sf.cglib.proxy.Enhancer.validate(Enhancer.java :374)
[junit] at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer. java:399)
[junit] at net.sf.cglib.proxy.Enhancer.create(Enhancer.java:3 18)
[junit] at org.springframework.aop.framework.Cglib2AopProxy.g etProxy(Cglib2AopProxy.java:194)
[junit] at org.springframework.aop.framework.Cglib2AopProxy.g etProxy(Cglib2AopProxy.java:150)
[junit] at org.springframework.aop.framework.ProxyFactoryBean .getSingletonInstance(ProxyFactoryBean.java:256)
[junit] at org.springframework.aop.framework.ProxyFactoryBean .setBeanFactory(ProxyFactoryBean.java:220)
[junit] at org.springframework.beans.factory.support.Abstract AutowireCapableBeanFactory.createBean(AbstractAuto wireCapableBeanFactory.java:349)
[junit] at org.springframework.beans.factory.support.Abstract BeanFactory.getBean(AbstractBeanFactory.java:223)
[junit] at org.springframework.beans.factory.support.Abstract BeanFactory.getBean(AbstractBeanFactory.java:147)
[junit] at org.springframework.beans.factory.support.DefaultL istableBeanFactory.preInstantiateSingletons(Defaul tListableBeanFactory.java:271)
[junit] at org.springframework.context.support.AbstractApplic ationContext.refresh(AbstractApplicationContext.ja va:312)
[junit] at org.springframework.context.support.ClassPathXmlAp plicationContext.<init>(ClassPathXmlApplicationContext.java:80)
[junit] at org.springframework.context.support.ClassPathXmlAp plicationContext.<init>(ClassPathXmlApplicationContext.java:65)
[junit] at org.springframework.test.AbstractSpringContextTest s.loadContextLocations(AbstractSpringContextTests. java:113)
[junit] at org.springframework.test.AbstractDependencyInjecti onSpringContextTests.loadContextLocations(Abstract DependencyInjectionSpringContextTests.java:147)
[junit] at org.springframework.test.AbstractSpringContextTest s.getContext(AbstractSpringContextTests.java:95)
[junit] at org.springframework.test.AbstractDependencyInjecti onSpringContextTests.setUp(AbstractDependencyInjec tionSpringContextTests.java:114)

Probably did something wrong?

<bean id="monitoredlokalDispoPositionenDao"
class="org.springframework.aop.framework.ProxyFactoryBean">
<property name="proxyInterfaces">
<value>com.apgsga.vk.preisermittlung.db.LokalDispoDao</value>
</property>
<property name="target">
<ref local="lokalDispoPositionenDao"/>
</property>
<property name="proxyTargetClass">
<value>true</value>
</property>
<property name="interceptorNames">
<list>
<value>performanceMontitor</value>
</list>
</property>
</bean>

robh

Jul 18th, 2005, 03:53 AM

Ah, you need to upgrade the version of CGLIB you are using. I've seen that particular error in an older version of CGLIB (can't remember which one exactly). Try using the CGLIB jar pacakged with the latest Spring release.

Rob

chenrici

Jul 18th, 2005, 06:24 AM

I updated the cglib to the newest version. That got me further.
But now i get a null pointer exception on the jdbcTemplate for the second invocation of a dao:

[junit] .com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtSelektionDaoI mpl.load : 0:00:09.994
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtSelektionDaoI mpl.load : 0:00:09.994
[junit] jdbcTemplate: null
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.createQuery : 0:00:00.000
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.createQuery : 0:00:00.000
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.AbstractContextCr eatingQueryDaoImpl.getParameterValueMap : 0:00:00.000
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.AbstractContextCr eatingQueryDaoImpl.getParameterValueMap : 0:00:00.000
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - Severe Error: java.lang.NullPointerException
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - Stacktrace:

I have tried different DataSource implementations:

<bean id="dataSource"
class="org.apache.commons.dbcp.BasicDataSource">
<property name="driverClassName">
<value>oracle.jdbc.OracleDriver</value>
</property>
<property name="url">
<value>jdbc:oracle:thin:@testserver:1521:test1</value>
</property>
<property name="password">
<value>xxxxx</value>
</property>
<property name="username">
<value>vk</value>
</property>
</bean>

All fail. I am not sure, if the problem is restricted to the JdbcTemplate.
I am still debugging, but maybe you saw already something similiar?

chenrici

Jul 18th, 2005, 08:21 AM

Additional information to above:
I construct the JdbcTemplate with the datasource property the afterPropertiesSet Method of a Dao Bean and store it locally.
When i retrieve the JdbcTemplate in the proxied Dao via getter Method it is null. Without the proxy it works fine?

robh

Jul 18th, 2005, 08:32 AM

Can you show the full stack trace and the test code?

Rob

chenrici

Jul 18th, 2005, 09:28 AM

Great thanx Rob for your help.
The log4j console output of the junit run, with debug enabled is quite extensive (1386).
Shall i post it?

Christoph

robh

Jul 18th, 2005, 01:38 PM

Just need the few lines that show the NullPointerException - say 10 lines.

Rob

chenrici

Jul 19th, 2005, 04:18 AM

The stack trace:

[junit] org.springframework.jdbc.datasource.DataSourceTran sactionManager - Using transaction object [org.springframework.jdbc.datasource.DataSourceTra nsactionManager$DataSourceTransactionObject@147358 f]
[junit] org.springframework.jdbc.datasource.DataSourceTran sactionManager - Creating new transaction with name [null]
[junit] org.springframework.jdbc.datasource.DataSourceTran sactionManager - Acquired Connection [org.apache.commons.dbcp.PoolableConnection@12c8fa 8] for JDBC transaction
[junit] org.springframework.jdbc.datasource.DataSourceTran sactionManager - Switching JDBC Connection [org.apache.commons.dbcp.PoolableConnection@12c8fa 8] to manual commit
[junit] org.springframework.transaction.support.Transactio nSynchronizationManager - Bound value [org.springframework.jdbc.datasource.ConnectionHol der@d5eb7] for key [org.apache.commons.dbcp.BasicDataSource@d6a05e ] to thread [main]
[junit] org.springframework.transaction.support.Transactio nSynchronizationManager - Initializing transaction synchronization
[junit] com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl$$EnhancerByCGLIB$$a73652c7 - getJdbcTemplate() : null
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.createQuery : 0:00:00.000
[junit] com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl - Invoking dummy get getParameterValueMap with : com.apgsga.vk.preisermittlung.db.LoaderContext@4a7 df6, parameter: <sprachid> : 1, <mitAnnullationen> : false, <annullationenAb> : null, <nurAktVertragsAbschnitte> : false, <nurPositiverFeedback> : false, <mitOptionen> : false, <pseudoBuchnungen> : false, <flaechenseltyp> : com.apgsga.vk.preisermittlung.service.FlaechenSele ktionsTyp@3, code: 3, type: Faktura, <kdvtId(s)> : 15, 4, 16, 205664, 18, 3, 102864, 12, 102967, 205660, 17, 2, 13, 102968, 6, 308746, 14, 102965, 10, 308655
[junit] com.apgsga.common.utils.PerformanceMonitor - com.apgsga.vk.preisermittlung.db.AbstractContextCr eatingQueryDaoImpl.getParameterValueMap : 0:00:00.000
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - Severe Error: java.lang.NullPointerException
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - Stacktrace:
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.db.AbstractDaoImpl$Q ueryByIdsWithINClause.execute(AbstractDaoImpl.java :335)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.db.AbstractContextCr eatingQueryDaoImpl.load(AbstractContextCreatingQue ryDaoImpl.java:73)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.db.LoaderImpl.loadZe ntralDispo(LoaderImpl.java:60)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.db.LoaderImpl.load(L oaderImpl.java:51)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl.berechne(BatchingServiceInterface Impl.java:153)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - com.apgsga.vk.preisermittlung.service.BatchService InterfaceImplTests.testService(BatchServiceInterfa ceImplTests.java:49)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - sun.reflect.NativeMethodAccessorImpl.invoke0(Nativ e Method)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - sun.reflect.NativeMethodAccessorImpl.invoke(Unknow n Source)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - sun.reflect.DelegatingMethodAccessorImpl.invoke(Un known Source)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - java.lang.reflect.Method.invoke(Unknown Source)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestCase.runTest(TestCase.java:154 )
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestCase.runBare(TestCase.java:127 )
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestResult$1.protect(TestResult.ja va:106)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestResult.runProtected(TestResult .java:124)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestResult.run(TestResult.java:109 )
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestCase.run(TestCase.java:118)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestSuite.runTest(TestSuite.java:2 08)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestSuite.run(TestSuite.java:203)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestSuite.runTest(TestSuite.java:2 08)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.framework.TestSuite.run(TestSuite.java:203)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.textui.TestRunner.doRun(TestRunner.java:116)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.textui.TestRunner.start(TestRunner.java:172)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - junit.textui.TestRunner.main(TestRunner.java:138)
[junit] com.apgsga.vk.preisermittlung.service.BatchingServ iceInterfaceImpl - Stacktrace finished.

Here the Bean and Proxy configuration:

[junit] org.springframework.beans.CachedIntrospectionResul ts - Getting BeanInfo for class [com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoI mpl]
[junit] org.springframework.beans.CachedIntrospectionResul ts - Caching PropertyDescriptors for class [com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoI mpl]
[junit] org.springframework.beans.CachedIntrospectionResul ts - Found property 'class' of type [java.lang.Class]
[junit] org.springframework.beans.CachedIntrospectionResul ts - Found property 'dataSource' of type [javax.sql.DataSource]
[junit] org.springframework.beans.CachedIntrospectionResul ts - Class [com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoI mpl] is cache-safe
[junit] org.springframework.beans.factory.support.BeanDefi nitionValueResolver - Resolving reference from property 'dataSource' in bean 'auftraegeAgpsFlDao' to bean 'dataSource'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Returning cached instance of singleton bean 'dataSource'
[junit] org.springframework.beans.BeanWrapperImpl - About to invoke write method [public final void com.apgsga.vk.preisermittlung.db.AbstractDaoImpl.s etDataSource(javax.sql.DataSource)] on object of class [com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoI mpl]
[junit] org.springframework.beans.BeanWrapperImpl - Invoked write method [public final void com.apgsga.vk.preisermittlung.db.AbstractDaoImpl.s etDataSource(javax.sql.DataSource)] with value of type [javax.sql.DataSource]
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking BeanPostProcessors before initialization of bean 'auftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking afterPropertiesSet() on bean with name 'auftraegeAgpsFlDao'
[junit] com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl - datasource in afterProperties set: org.apache.commons.dbcp.BasicDataSource@d6a05e
[junit] com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl - jdbcTemplate in afterProperties set: org.springframework.jdbc.core.JdbcTemplate@193c0cf
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking BeanPostProcessors after initialization of bean 'auftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Creating shared instance of singleton bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Creating instance of bean 'monitoredauftraegeAgpsFlDao' with merged definition [Root bean with class [org.springframework.aop.framework.ProxyFactoryBea n] defined in class path resource [batchtestbeans.xml]]
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking BeanPostProcessors before instantiation of bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.core.CollectionFactory - Creating java.util.IdentityHashMap
[junit] org.springframework.beans.CachedIntrospectionResul ts - Using cached introspection results for class [org.springframework.aop.framework.ProxyFactoryBea n]
[junit] org.springframework.beans.factory.support.BeanDefi nitionValueResolver - Resolving reference from property 'target' in bean 'monitoredauftraegeAgpsFlDao' to bean 'auftraegeAgpsFlDao'
[junit] org.springframework.core.CollectionFactory - Creating java.util.LinkedHashSet
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Returning cached instance of singleton bean 'auftraegeAgpsFlDao'
[junit] org.springframework.beans.BeanWrapperImpl - Converting String to [class [Ljava.lang.String;] using property editor [org.springframework.beans.propertyeditors.StringA rrayPropertyEditor@1576e70]
[junit] org.springframework.beans.BeanWrapperImpl - About to invoke write method [public void org.springframework.aop.framework.ProxyFactoryBean .setProxyInterfaces(java.lang.String[]) throws java.lang.ClassNotFoundException] on object of class [org.springframework.aop.framework.ProxyFactoryBea n]
[junit] org.springframework.aop.framework.ProxyFactoryBean - Added new aspect interface: com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDao
[junit] org.springframework.beans.BeanWrapperImpl - Invoked write method [public void org.springframework.aop.framework.ProxyFactoryBean .setProxyInterfaces(java.lang.String[]) throws java.lang.ClassNotFoundException] with value of type [[Ljava.lang.String;]
[junit] org.springframework.beans.BeanWrapperImpl - About to invoke write method [public void org.springframework.aop.framework.AdvisedSupport.s etTarget(java.lang.Object)] on object of class [org.springframework.aop.framework.ProxyFactoryBea n]
[junit] org.springframework.beans.BeanWrapperImpl - Invoked write method [public void org.springframework.aop.framework.AdvisedSupport.s etTarget(java.lang.Object)] with value of type [java.lang.Object]
[junit] org.springframework.beans.BeanWrapperImpl - Converting String to [boolean] using property editor [org.springframework.beans.propertyeditors.CustomB ooleanEditor@11381e7]
[junit] org.springframework.beans.BeanWrapperImpl - About to invoke write method [public void org.springframework.aop.framework.ProxyConfig.setP roxyTargetClass(boolean)] on object of class [org.springframework.aop.framework.ProxyFactoryBea n]
[junit] org.springframework.beans.BeanWrapperImpl - Invoked write method [public void org.springframework.aop.framework.ProxyConfig.setP roxyTargetClass(boolean)] with value of type [boolean]
[junit] org.springframework.beans.BeanWrapperImpl - About to invoke write method [public void org.springframework.aop.framework.ProxyFactoryBean .setInterceptorNames(java.lang.String[])] on object of class [org.springframework.aop.framework.ProxyFactoryBea n]
[junit] org.springframework.beans.BeanWrapperImpl - Invoked write method [public void org.springframework.aop.framework.ProxyFactoryBean .setInterceptorNames(java.lang.String[])] with value of type [[Ljava.lang.String;]
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking setBeanFactory on BeanFactoryAware bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.aop.framework.ProxyFactoryBean - Configuring advisor or advice 'performanceMontitor'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Returning cached instance of singleton bean 'performanceMontitor'
[junit] org.springframework.aop.framework.ProxyFactoryBean - Adding advisor or TargetSource [com.apgsga.common.utils.PerformanceMonitor@7f4 ec] with name [performanceMontitor]
[junit] org.springframework.aop.framework.ProxyFactoryBean - Adding advisor with name [performanceMontitor]
[junit] org.springframework.aop.framework.ProxyFactoryBean - Not refreshing target: bean name not specified in interceptorNames
[junit] org.springframework.aop.framework.Cglib2AopProxy - Creating CGLIB2 proxy for [com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoI mpl]
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public com.apgsga.vk.preisermittlung.db.AbstractDaoImpl$A bstractQuery com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.createQuery(org.springframework.jdbc.core.JdbcT emplate,com.apgsga.vk.preisermittlung.db.LoaderCon text) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateSqlBlockFromParameter(com.apgsga.vk.pre isermittlung.db.LoaderContext,java.lang.StringBuff er) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateSqlBlockForAg(com.apgsga.vk.preisermitt lung.db.LoaderContext,java.lang.StringBuffer) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateAnnullationsBlkFuerAg(com.apgsga.vk.pre isermittlung.db.LoaderContext,java.lang.StringBuff er) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateSqlBlockForAgps(com.apgsga.vk.preisermi ttlung.db.LoaderContext,java.lang.StringBuffer) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateAnnullationsBlkFuerAgps(com.apgsga.vk.p reisermittlung.db.LoaderContext,java.lang.StringBu ffer) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateSqlBlockForFlzo(com.apgsga.vk.preisermi ttlung.db.LoaderContext,java.lang.StringBuffer) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public void com.apgsga.vk.preisermittlung.db.KdvtAgAgpsFlDaoIm pl.generateAnnullationsBlkFuerFlzo(com.apgsga.vk.p reisermittlung.db.LoaderContext,java.lang.StringBu ffer) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public java.util.Map com.apgsga.vk.preisermittlung.db.AbstractContextCr eatingQueryDaoImpl.getParameterValueMap(com.apgsga .vk.preisermittlung.db.LoaderContext) - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public native int java.lang.Object.hashCode() - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Found equals() method - using INVOKE_EQUALS
[junit] org.springframework.aop.framework.Cglib2AopProxy - Unable to apply any optimisations to advised method public java.lang.String java.lang.Object.toString() - using AOP_PROXY
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract int org.springframework.aop.framework.Advised.indexOf( org.springframework.aop.Advisor) is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract org.springframework.aop.TargetSource org.springframework.aop.framework.Advised.getTarge tSource() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract org.springframework.aop.Advisor[] org.springframework.aop.framework.Advised.getAdvis ors() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.addAdvis or(org.springframework.aop.Advisor) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.addAdvis or(int,org.springframework.aop.Advisor) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.setTarge tSource(org.springframework.aop.TargetSource) is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract java.lang.Class[] org.springframework.aop.framework.Advised.getProxi edInterfaces() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.addAdvic e(int,org.aopalliance.aop.Advice) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.addAdvic e(org.aopalliance.aop.Advice) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.isInterf aceProxied(java.lang.Class) is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.removeAd vice(org.aopalliance.aop.Advice) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.removeAd visor(int) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.removeAd visor(org.springframework.aop.Advisor) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.replaceA dvisor(org.springframework.aop.Advisor,org.springf ramework.aop.Advisor) throws org.springframework.aop.framework.AopConfigExcepti on is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract java.lang.String org.springframework.aop.framework.Advised.toProxyC onfigString() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.isFrozen () is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.isProxyT argetClass() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract void org.springframework.aop.framework.Advised.setExpos eProxy(boolean) is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.aop.framework.Cglib2AopProxy - Method public abstract boolean org.springframework.aop.framework.Advised.isExpose Proxy() is declared on Advised - using DISPATCH_ADVISED
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking BeanPostProcessors before initialization of bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Invoking BeanPostProcessors after initialization of bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Calling code asked for FactoryBean instance for name 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Returning cached instance of singleton bean 'monitoredauftraegeAgpsFlDao'
[junit] org.springframework.beans.factory.support.DefaultL istableBeanFactory - Bean with name 'monitoredauftraegeAgpsFlDao' is a factory bean

robh

Jul 19th, 2005, 04:46 AM

Can you show this method: AbstractDaoImpl$QueryByIdsWithINClause.execute

It looks from the stack trace that this is where the NPE is occuring on line 335

Rob

chenrici

Jul 19th, 2005, 07:54 AM

protected static class QueryByIdsWithINClause extends AbstractQuery {

private final transient String sqlTempl;

private final transient String wherePlceHolder;

protected QueryByIdsWithINClause(final JdbcTemplate jdbtTempl,
final String sqlTempl, final String wherePlceHolder) {
super(jdbtTempl);
this.sqlTempl = sqlTempl;
this.wherePlceHolder = wherePlceHolder;
}

protected Object execute(final QueryParameters paramter) {
final StringBuffer buffer = new StringBuffer();
boolean first = true;
final Iterator it = paramter.getParentKeyMap().mapIterator();
while (it.hasNext()) {
final Number kdvtId = (Number) it.next();
if (first) {
first = false;
} else {
buffer.append(", ");
}
buffer.append(kdvtId.toString());
}
final String sql = sqlTempl.replaceFirst(wherePlceHolder, buffer
.toString());
return jdbcTml.query(sql, paramter.getRsExtractor());
}
}

The npe comes from jdbcTml being null.
jdbcTml is initialized in the constructor of the superclass:

protected static abstract class AbstractQuery {

/**
* Logger available to subclasses.
*/
protected final Log logger = LogFactory.getLog(getClass());

protected transient final JdbcTemplate jdbcTml;

protected AbstractQuery(final JdbcTemplate jdbcTml) {
super();
this.jdbcTml = jdbcTml;
}

protected abstract Object execute(final QueryParameters parameter);
}

Both are innerclasses of a abstract superclass of the dao bean, which is proxyed:

public abstract class AbstractDaoImpl implements InitializingBean {

/**
* Logger available to subclasses.
*/
protected final Log logger = LogFactory.getLog(getClass());

// Kolonnen Namen

protected final static String COL_KDVT_ID = Messages
.getString("Db.Column.kdvt_id");

protected final static String COL_SPRACHE_ID = Messages
.getString("Db.Column.sprache_id");

// Exception Texte

protected final static String EXC_MAPPING = Messages
.getString("Db.Exception.Mapping");

final static String EXC_NULL = Messages.getString("Db.Exception.Null");

private DataSource dataSource;

private JdbcTemplate jdbcTemplate;

/**
*
*/
public AbstractDaoImpl() {
super();
}

/**
* @return Returns the dataSource.
*/
public final DataSource getDataSource() {
return dataSource;
}

/**
* @param dataSource
* The dataSource to set.
*/
public final void setDataSource(final DataSource dataSource) {
this.dataSource = dataSource;

}

/*
* (non-Javadoc)
*
* @see org.springframework.beans.factory.InitializingBean #afterPropertiesSet()
*/
final public void afterPropertiesSet() {
jdbcTemplate = new JdbcTemplate(dataSource);
doInAfterPropertiesSet();
}

protected final JdbcTemplate getJdbcTemplate() {
return jdbcTemplate;
}

The JdbcTemplate is created in the afterPropertiesSet method of AbstractDaoImpl .

QueryByIdsWithINClause ist created and executed in the proxied Bean:

/*
* (non-Javadoc)
*
* @see com.apgsga.vk.preisermittlung.db.DetailLoadingDao# loadForParents(java.util.Collection)
*/
public final void load(final LoaderContext loaderContext) {

final IterableMap keysMap = getKeysMap(loaderContext);
final ResultSetExtractor rex = createResultSetExtractor(loaderContext);
final AbstractQuery theQuery = createQuery(getJdbcTemplate(),
loaderContext);
if (theQuery == null) {
return;
}
final QueryParameters qparm = new QueryParameters(keysMap,
loaderContext, rex);
qparm.add(getParameterValueMap(loaderContext));
theQuery.execute(qparm);
}

The JdbcTemplate is already null in the getJdbcTemplate() method.

chenrici

Aug 15th, 2005, 08:04 AM

Setting "proxyTargetClass" to "true", as Rob suggested, was the solution:

The reason for the NPE, was that the proxied method from the interface of the Bean Class, where final, so CGLIB could'nt subclass them as decribed in the Spring Reference Dokumentation: 5.5.4. Proxying classes.

To see the invoking class - instead of the implementing super class, i had to change the Performance Monitor a bit:

String name = invocation.getThis().getClass().getName()
+ "." + invocation.getMethod().getName();

instead of:

String name = invocation.getMethod().getDeclaringClass().getName () + "." + invocation.getMethod().getName();

chenrici

May 18th, 2006, 04:28 PM

There was an issue with cglib and non public methods.
It "simply" did'nt see them .... as an afterthought probably quite understandable.
So beware using cglib: "what you see is what you get" ;-)